Revert "Make writing file via container in tests sync for real this time by enclosing multiple commands in quotes"

davidz627 · web-flow · commit c23c4296d1cc · 2019-11-04T11:26:34.000-08:00
diff --git a/test/e2e/framework/framework.go b/test/e2e/framework/framework.go
@@ -478,7 +478,7 @@ func (f *Framework) WriteFileViaContainer(podName, containerName string, path st
 			return fmt.Errorf("Unsupported character in string to write: %v", c)
 		}
 	}
-	command := fmt.Sprintf("\"echo '%s' > '%s'; sync\"", contents, path)
+	command := fmt.Sprintf("echo '%s' > '%s'; sync", contents, path)
 	stdout, stderr, err := kubectlExecWithRetry(f.Namespace.Name, podName, containerName, "--", "/bin/sh", "-c", command)
 	if err != nil {
 		Logf("error running kubectl exec to write file: %v\nstdout=%v\nstderr=%v)", err, string(stdout), string(stderr))

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,7 @@ func (f *Framework) WriteFileViaContainer(podName, containerName string, path st`
`478`	`478`	`return fmt.Errorf("Unsupported character in string to write: %v", c)`
`479`	`479`	`}`
`480`	`480`	`}`
`481`		`- command := fmt.Sprintf("\"echo '%s' > '%s'; sync\"", contents, path)`
	`481`	`+ command := fmt.Sprintf("echo '%s' > '%s'; sync", contents, path)`
`482`	`482`	`stdout, stderr, err := kubectlExecWithRetry(f.Namespace.Name, podName, containerName, "--", "/bin/sh", "-c", command)`
`483`	`483`	`if err != nil {`
`484`	`484`	`Logf("error running kubectl exec to write file: %v\nstdout=%v\nstderr=%v)", err, string(stdout), string(stderr))`