Skip to content

Commit c2b312b

Browse files
authored
Merge pull request kubernetes#85790 from tanjunchen/fix-staticcheck-pkg-printers
fix staticcheck in pkg/printers
2 parents fe80f32 + 40911e7 commit c2b312b

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

hack/.staticcheck_failures

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ pkg/kubelet/cm/devicemanager
1818
pkg/kubelet/pluginmanager/operationexecutor
1919
pkg/kubelet/pluginmanager/pluginwatcher
2020
pkg/kubelet/remote
21-
pkg/printers
2221
pkg/probe/http
2322
pkg/proxy/healthcheck
2423
pkg/proxy/iptables

pkg/printers/tablegenerator.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ type PrintHandler interface {
4545
type handlerEntry struct {
4646
columnDefinitions []metav1.TableColumnDefinition
4747
printFunc reflect.Value
48-
args []reflect.Value
4948
}
5049

5150
// HumanReadableGenerator is an implementation of TableGenerator used to generate
@@ -160,7 +159,7 @@ func ValidateRowPrintHandlerFunc(printFunc reflect.Value) error {
160159
funcType := printFunc.Type()
161160
if funcType.NumIn() != 2 || funcType.NumOut() != 2 {
162161
return fmt.Errorf("invalid print handler." +
163-
"Must accept 2 parameters and return 2 value.")
162+
"Must accept 2 parameters and return 2 value")
164163
}
165164
if funcType.In(1) != reflect.TypeOf((*GenerateOptions)(nil)).Elem() ||
166165
funcType.Out(0) != reflect.TypeOf((*[]metav1.TableRow)(nil)).Elem() ||

0 commit comments

Comments
 (0)