Skip to content

Commit c3d483b

Browse files
authored
Merge pull request kubernetes#89323 from tanjunchen/remove-invalid-dependency-waitForPod-001
use e2epod.WaitForPodNotFoundInNamespace directly
2 parents fb9810c + d18e656 commit c3d483b

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

test/e2e/framework/framework.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -515,11 +515,6 @@ func (f *Framework) WaitForPodTerminated(podName, reason string) error {
515515
return e2epod.WaitForPodTerminatedInNamespace(f.ClientSet, podName, reason, f.Namespace.Name)
516516
}
517517

518-
// WaitForPodNotFound waits for the pod to be completely terminated (not "Get-able").
519-
func (f *Framework) WaitForPodNotFound(podName string, timeout time.Duration) error {
520-
return e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, podName, f.Namespace.Name, timeout)
521-
}
522-
523518
// WaitForPodReady waits for the pod to flip to ready in the namespace.
524519
func (f *Framework) WaitForPodReady(podName string) error {
525520
return e2epod.WaitTimeoutForPodReadyInNamespace(f.ClientSet, podName, f.Namespace.Name, PodStartTimeout)

test/e2e/network/network_policy.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -718,15 +718,15 @@ var _ = SIGDescribe("NetworkPolicy [LinuxOnly]", func() {
718718
framework.ExpectNoError(err, "Error creating Network Policy %v: %v", policy.ObjectMeta.Name, err)
719719

720720
testCanConnect(f, f.Namespace, "client-a", service, clientAAllowedPort)
721-
err = f.WaitForPodNotFound("client-a", framework.PodDeleteTimeout)
721+
e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, "client-a", f.Namespace.Name, framework.PodDeleteTimeout)
722722
framework.ExpectNoError(err, "Expected pod to be not found.")
723723

724724
testCannotConnect(f, f.Namespace, "client-b", service, clientAAllowedPort)
725-
err = f.WaitForPodNotFound("client-b", framework.PodDeleteTimeout)
725+
e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, "client-b", f.Namespace.Name, framework.PodDeleteTimeout)
726726
framework.ExpectNoError(err, "Expected pod to be not found.")
727727

728728
testCannotConnect(f, f.Namespace, "client-a", service, clientANotAllowedPort)
729-
err = f.WaitForPodNotFound("client-a", framework.PodDeleteTimeout)
729+
e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, "client-a", f.Namespace.Name, framework.PodDeleteTimeout)
730730
framework.ExpectNoError(err, "Expected pod to be not found.")
731731

732732
const (
@@ -765,7 +765,7 @@ var _ = SIGDescribe("NetworkPolicy [LinuxOnly]", func() {
765765
defer cleanupNetworkPolicy(f, policy)
766766

767767
testCannotConnect(f, f.Namespace, "client-b", service, clientBNotAllowedPort)
768-
err = f.WaitForPodNotFound("client-b", framework.PodDeleteTimeout)
768+
e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, "client-b", f.Namespace.Name, framework.PodDeleteTimeout)
769769
framework.ExpectNoError(err, "Expected pod to be not found.")
770770

771771
testCannotConnect(f, f.Namespace, "client-a", service, clientBNotAllowedPort)

test/e2e/storage/utils/utils.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ func TestVolumeUnmountsFromDeletedPodWithForceOption(c clientset.Interface, f *f
307307

308308
ginkgo.By("Starting the kubelet and waiting for pod to delete.")
309309
KubeletCommand(KStart, c, clientPod)
310-
err = f.WaitForPodNotFound(clientPod.Name, framework.PodDeleteTimeout)
310+
err = e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, clientPod.Name, f.Namespace.Name, framework.PodDeleteTimeout)
311311
if err != nil {
312312
framework.ExpectNoError(err, "Expected pod to be not found.")
313313
}
@@ -393,7 +393,7 @@ func TestVolumeUnmapsFromDeletedPodWithForceOption(c clientset.Interface, f *fra
393393

394394
ginkgo.By("Starting the kubelet and waiting for pod to delete.")
395395
KubeletCommand(KStart, c, clientPod)
396-
err = f.WaitForPodNotFound(clientPod.Name, framework.PodDeleteTimeout)
396+
err = e2epod.WaitForPodNotFoundInNamespace(f.ClientSet, clientPod.Name, f.Namespace.Name, framework.PodDeleteTimeout)
397397
framework.ExpectNoError(err, "Expected pod to be not found.")
398398

399399
if forceDelete {

0 commit comments

Comments
 (0)