Skip to content

Commit c577031

Browse files
authored
Merge pull request kubernetes#76741 from logicalhan/install-tunneler-bugs
Two bugfixes in installTunneler
2 parents a380c29 + 6de7082 commit c577031

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

pkg/master/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ go_library(
129129
"//staging/src/k8s.io/client-go/kubernetes/typed/core/v1:go_default_library",
130130
"//staging/src/k8s.io/client-go/kubernetes/typed/discovery/v1beta1:go_default_library",
131131
"//staging/src/k8s.io/client-go/rest:go_default_library",
132-
"//vendor/github.com/prometheus/client_golang/prometheus:go_default_library",
133132
"//vendor/k8s.io/klog:go_default_library",
134133
"//vendor/k8s.io/utils/integer:go_default_library",
135134
"//vendor/k8s.io/utils/net:go_default_library",

pkg/master/master.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ import (
8989
"k8s.io/kubernetes/pkg/serviceaccount"
9090
nodeutil "k8s.io/kubernetes/pkg/util/node"
9191

92-
"github.com/prometheus/client_golang/prometheus"
9392
"k8s.io/klog"
9493

9594
// RESTStorage installers
@@ -469,15 +468,10 @@ func (m *Master) InstallLegacyAPI(c *completedConfig, restOptionsGetter generic.
469468

470469
func (m *Master) installTunneler(nodeTunneler tunneler.Tunneler, nodeClient corev1client.NodeInterface) {
471470
nodeTunneler.Run(nodeAddressProvider{nodeClient}.externalAddresses)
472-
m.GenericAPIServer.AddHealthChecks(healthz.NamedCheck("SSH Tunnel Check", tunneler.TunnelSyncHealthChecker(nodeTunneler)))
473-
prometheus.NewGaugeFunc(prometheus.GaugeOpts{
474-
Name: "apiserver_proxy_tunnel_sync_duration_seconds",
475-
Help: "The time since the last successful synchronization of the SSH tunnels for proxy requests.",
476-
}, func() float64 { return float64(nodeTunneler.SecondsSinceSync()) })
477-
prometheus.NewGaugeFunc(prometheus.GaugeOpts{
478-
Name: "apiserver_proxy_tunnel_sync_latency_secs",
479-
Help: "(Deprecated) The time since the last successful synchronization of the SSH tunnels for proxy requests.",
480-
}, func() float64 { return float64(nodeTunneler.SecondsSinceSync()) })
471+
err := m.GenericAPIServer.AddHealthChecks(healthz.NamedCheck("SSH Tunnel Check", tunneler.TunnelSyncHealthChecker(nodeTunneler)))
472+
if err != nil {
473+
klog.Errorf("Failed adding ssh tunnel health check %v\n", err)
474+
}
481475
}
482476

483477
// RESTStorageProvider is a factory type for REST storage.

0 commit comments

Comments
 (0)