Skip to content

Commit c6a38a9

Browse files
authored
Merge pull request kubernetes#85229 from liggitt/kubeadm-imports
guard kubeadm dependencies on k8s.io/kubernetes
2 parents f5f0244 + 752cda4 commit c6a38a9

File tree

4 files changed

+4
-52
lines changed

4 files changed

+4
-52
lines changed

cmd/kubeadm/.import-restrictions

Lines changed: 1 addition & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
]
3232
},
3333
{
34-
"SelectorRegexp": "k8s[.]io/kubernetes/cmd",
34+
"SelectorRegexp": "k8s[.]io/kubernetes",
3535
"AllowedPrefixes": [
3636
"k8s.io/kubernetes/cmd/kubeadm"
3737
]
@@ -47,52 +47,6 @@
4747
"k8s.io/utils/trace"
4848
]
4949
},
50-
{
51-
"SelectorRegexp": "k8s[.]io/kubernetes/pkg",
52-
"AllowedPrefixes": [
53-
"k8s.io/kubernetes/pkg/api/legacyscheme",
54-
"k8s.io/kubernetes/pkg/apis/autoscaling",
55-
"k8s.io/kubernetes/pkg/apis/core",
56-
"k8s.io/kubernetes/pkg/api/service",
57-
"k8s.io/kubernetes/pkg/apis/apps",
58-
"k8s.io/kubernetes/pkg/apis/rbac",
59-
"k8s.io/kubernetes/pkg/apis/scheduling",
60-
"k8s.io/kubernetes/pkg/api/v1/pod",
61-
"k8s.io/kubernetes/pkg/api/v1/service",
62-
"k8s.io/kubernetes/pkg/capabilities",
63-
"k8s.io/kubernetes/pkg/controller",
64-
"k8s.io/kubernetes/pkg/features",
65-
"k8s.io/kubernetes/pkg/fieldpath",
66-
"k8s.io/kubernetes/pkg/kubelet/apis",
67-
"k8s.io/kubernetes/pkg/kubelet/cm/cpuset",
68-
"k8s.io/kubernetes/pkg/kubelet/qos",
69-
"k8s.io/kubernetes/pkg/kubelet/types",
70-
"k8s.io/kubernetes/pkg/master/ports",
71-
"k8s.io/kubernetes/pkg/proxy/apis/config",
72-
"k8s.io/kubernetes/pkg/proxy",
73-
"k8s.io/kubernetes/pkg/registry/core/service/allocator",
74-
"k8s.io/kubernetes/pkg/registry/core/service/ipallocator",
75-
"k8s.io/kubernetes/pkg/security/apparmor",
76-
"k8s.io/kubernetes/pkg/serviceaccount",
77-
"k8s.io/kubernetes/pkg/util/async",
78-
"k8s.io/kubernetes/pkg/util/conntrack",
79-
"k8s.io/kubernetes/pkg/util/hash",
80-
"k8s.io/kubernetes/pkg/util/iptables",
81-
"k8s.io/kubernetes/pkg/util/parsers",
82-
"k8s.io/kubernetes/pkg/util/sysctl",
83-
"k8s.io/kubernetes/pkg/util/taints"
84-
],
85-
"ForbiddenPrefixes": [
86-
"k8s.io/kubernetes/pkg/cloudprovider/providers",
87-
"k8s.io/kubernetes/pkg/cloudprovider/providers/aws",
88-
"k8s.io/kubernetes/pkg/cloudprovider/providers/azure",
89-
"k8s.io/kubernetes/pkg/cloudprovider/providers/fake",
90-
"k8s.io/kubernetes/pkg/cloudprovider/providers/gce",
91-
"k8s.io/kubernetes/pkg/cloudprovider/providers/openstack",
92-
"k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere",
93-
"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"
94-
]
95-
},
9650
{
9751
"SelectorRegexp": "github[.]com",
9852
"AllowedPrefixes": [

cmd/kubeadm/app/util/apiclient/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ go_library(
1919
deps = [
2020
"//cmd/kubeadm/app/constants:go_default_library",
2121
"//cmd/kubeadm/app/util:go_default_library",
22-
"//pkg/kubelet/types:go_default_library",
2322
"//staging/src/k8s.io/api/apps/v1:go_default_library",
2423
"//staging/src/k8s.io/api/core/v1:go_default_library",
2524
"//staging/src/k8s.io/api/rbac/v1:go_default_library",

cmd/kubeadm/app/util/apiclient/clientbacked_dryrun.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func (clg *ClientBackedDryRunGetter) Client() clientset.Interface {
113113
}
114114

115115
// decodeUnversionedIntoAPIObject converts the *unversioned.Unversioned object returned from the dynamic client
116-
// to bytes; and then decodes it back _to an external api version (k8s.io/api vs k8s.io/kubernetes/pkg/api*)_ using the normal API machinery
116+
// to bytes; and then decodes it back _to an external api version (k8s.io/api)_ using the normal API machinery
117117
func decodeUnstructuredIntoAPIObject(action core.Action, unstructuredObj runtime.Unstructured) (runtime.Object, error) {
118118
objBytes, err := json.Marshal(unstructuredObj)
119119
if err != nil {

cmd/kubeadm/app/util/apiclient/wait.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,13 @@ import (
2424

2525
"github.com/pkg/errors"
2626

27-
"k8s.io/api/core/v1"
27+
v1 "k8s.io/api/core/v1"
2828
apierrors "k8s.io/apimachinery/pkg/api/errors"
2929
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3030
netutil "k8s.io/apimachinery/pkg/util/net"
3131
"k8s.io/apimachinery/pkg/util/wait"
3232
clientset "k8s.io/client-go/kubernetes"
3333
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
34-
kubetypes "k8s.io/kubernetes/pkg/kubelet/types"
3534
)
3635

3736
// Waiter is an interface for waiting for criteria in Kubernetes to happen
@@ -246,7 +245,7 @@ func getStaticPodSingleHash(client clientset.Interface, nodeName string, compone
246245
return "", err
247246
}
248247

249-
staticPodHash := staticPod.Annotations[kubetypes.ConfigHashAnnotationKey]
248+
staticPodHash := staticPod.Annotations["kubernetes.io/config.hash"]
250249
fmt.Printf("Static pod: %s hash: %s\n", staticPodName, staticPodHash)
251250
return staticPodHash, nil
252251
}

0 commit comments

Comments
 (0)