Skip to content

Commit c6ac8ea

Browse files
committed
duplicate iteration variable in go func
1 parent e3dde36 commit c6ac8ea

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

staging/src/k8s.io/client-go/rest/watch/decoder_test.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,36 +50,37 @@ func TestDecoder(t *testing.T) {
5050
decoder := restclientwatch.NewDecoder(streaming.NewDecoder(out, getDecoder()), getDecoder())
5151
expect := &v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}}
5252
encoder := json.NewEncoder(in)
53-
go func(eventType interface{}) {
53+
eType := eventType
54+
go func() {
5455
data, err := runtime.Encode(scheme.Codecs.LegacyCodec(v1.SchemeGroupVersion), expect)
5556
if err != nil {
5657
t.Fatalf("Unexpected error %v", err)
5758
}
5859
event := metav1.WatchEvent{
59-
Type: string(eventType),
60+
Type: string(eType),
6061
Object: runtime.RawExtension{Raw: json.RawMessage(data)},
6162
}
6263
if err := encoder.Encode(&event); err != nil {
6364
t.Errorf("Unexpected error %v", err)
6465
}
6566
in.Close()
66-
}(eventType)
67+
}()
6768

6869
done := make(chan struct{})
69-
go func(eventType interface{}) {
70+
go func() {
7071
action, got, err := decoder.Decode()
7172
if err != nil {
7273
t.Fatalf("Unexpected error %v", err)
7374
}
74-
if e, a := eventType, action; e != a {
75+
if e, a := eType, action; e != a {
7576
t.Errorf("Expected %v, got %v", e, a)
7677
}
7778
if e, a := expect, got; !apiequality.Semantic.DeepDerivative(e, a) {
7879
t.Errorf("Expected %v, got %v", e, a)
7980
}
8081
t.Logf("Exited read")
8182
close(done)
82-
}(eventType)
83+
}()
8384
<-done
8485

8586
done = make(chan struct{})

0 commit comments

Comments
 (0)