Skip to content

Commit c6f9b40

Browse files
committed
test(kuberuntime): deflake TestRecordOperation
Avoid using hard-coded port Signed-off-by: knight42 <[email protected]>
1 parent 0f466ba commit c6f9b40

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/kubelet/kuberuntime/instrumented_services_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,16 @@ func TestRecordOperation(t *testing.T) {
3434
legacyregistry.MustRegister(metrics.RuntimeOperationsDuration)
3535
legacyregistry.MustRegister(metrics.RuntimeOperationsErrors)
3636

37-
temporalServer := "127.0.0.1:1234"
38-
l, err := net.Listen("tcp", temporalServer)
37+
l, err := net.Listen("tcp", "127.0.0.1:0")
3938
assert.NoError(t, err)
4039
defer l.Close()
4140

42-
prometheusURL := "http://" + temporalServer + "/metrics"
41+
prometheusURL := "http://" + l.Addr().String() + "/metrics"
4342
mux := http.NewServeMux()
4443
//lint:ignore SA1019 ignore deprecated warning until we move off of global registries
4544
mux.Handle("/metrics", legacyregistry.Handler())
4645
server := &http.Server{
47-
Addr: temporalServer,
46+
Addr: l.Addr().String(),
4847
Handler: mux,
4948
}
5049
go func() {

0 commit comments

Comments
 (0)