Skip to content

Commit cae11a1

Browse files
committed
fixed golint error
exported func ToForwardingRuleComposite returns unexported type *gce.forwardingRuleComposite, which can be annoying to use
1 parent c09c8ab commit cae11a1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

staging/src/k8s.io/legacy-cloud-providers/gce/gce_loadbalancer_internal.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -768,8 +768,8 @@ func (f *forwardingRuleComposite) Equal(other *forwardingRuleComposite) bool {
768768
f.allowGlobalAccess == other.allowGlobalAccess
769769
}
770770

771-
// ToForwardingRuleComposite converts a compute beta or GA ForwardingRule into the composite type
772-
func ToForwardingRuleComposite(rule interface{}) (frc *forwardingRuleComposite, err error) {
771+
// toForwardingRuleComposite converts a compute beta or GA ForwardingRule into the composite type
772+
func toForwardingRuleComposite(rule interface{}) (frc *forwardingRuleComposite, err error) {
773773
switch fr := rule.(type) {
774774
case *compute.ForwardingRule:
775775
frc = &forwardingRuleComposite{
@@ -895,12 +895,12 @@ func (g *Cloud) ensureInternalForwardingRule(existingFwdRule *compute.Forwarding
895895
if err != nil {
896896
return err
897897
}
898-
oldFRC, err = ToForwardingRuleComposite(betaRule)
898+
oldFRC, err = toForwardingRuleComposite(betaRule)
899899
case meta.VersionGA:
900-
oldFRC, err = ToForwardingRuleComposite(existingFwdRule)
900+
oldFRC, err = toForwardingRuleComposite(existingFwdRule)
901901
default:
902902
klog.Errorf("invalid version string for %s, assuming GA", existingFwdRule.Name)
903-
oldFRC, err = ToForwardingRuleComposite(existingFwdRule)
903+
oldFRC, err = toForwardingRuleComposite(existingFwdRule)
904904
}
905905
if err != nil {
906906
return err

staging/src/k8s.io/legacy-cloud-providers/gce/gce_loadbalancer_internal_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1204,15 +1204,15 @@ func TestForwardingRuleCompositeEqual(t *testing.T) {
12041204
if err != nil {
12051205
t.Errorf("Unexpected error %v", err)
12061206
}
1207-
frcGA, err := ToForwardingRuleComposite(gaRule)
1207+
frcGA, err := toForwardingRuleComposite(gaRule)
12081208
if err != nil {
12091209
t.Errorf("Unexpected error %v", err)
12101210
}
1211-
frcBeta, err := ToForwardingRuleComposite(betaRule)
1211+
frcBeta, err := toForwardingRuleComposite(betaRule)
12121212
if err != nil {
12131213
t.Errorf("Unexpected error %v", err)
12141214
}
1215-
frcBetaGlobalAccess, err := ToForwardingRuleComposite(betaRuleGlobalAccess)
1215+
frcBetaGlobalAccess, err := toForwardingRuleComposite(betaRuleGlobalAccess)
12161216
if err != nil {
12171217
t.Errorf("Unexpected error %v", err)
12181218
}

0 commit comments

Comments
 (0)