Merge pull request kubernetes#94338 from JeremyShih/fix-golint-error-in-admissionregistration

k8s-ci-robot · web-flow · commit cc14d5f3a157 · 2020-09-02T10:37:19.000-07:00
fixed golint error in pkg/apis/admissionregistration/validation
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -8,7 +8,6 @@ pkg/apis/abac/v1beta1
 pkg/apis/admission
 pkg/apis/admissionregistration/v1
 pkg/apis/admissionregistration/v1beta1
-pkg/apis/admissionregistration/validation
 pkg/apis/apps/v1
 pkg/apis/apps/v1beta1
 pkg/apis/apps/v1beta2
diff --git a/pkg/apis/admissionregistration/v1/defaults.go b/pkg/apis/admissionregistration/v1/defaults.go
@@ -27,6 +27,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error {
 	return RegisterDefaults(scheme)
 }
 
+// SetDefaults_ValidatingWebhook sets defaults for webhook validating
 func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1.ValidatingWebhook) {
 	if obj.FailurePolicy == nil {
 		policy := admissionregistrationv1.Fail
@@ -50,6 +51,7 @@ func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1.ValidatingWebhoo
 	}
 }
 
+// SetDefaults_MutatingWebhook sets defaults for webhook mutating
 func SetDefaults_MutatingWebhook(obj *admissionregistrationv1.MutatingWebhook) {
 	if obj.FailurePolicy == nil {
 		policy := admissionregistrationv1.Fail
@@ -77,6 +79,7 @@ func SetDefaults_MutatingWebhook(obj *admissionregistrationv1.MutatingWebhook) {
 	}
 }
 
+// SetDefaults_Rule sets defaults for webhook rule
 func SetDefaults_Rule(obj *admissionregistrationv1.Rule) {
 	if obj.Scope == nil {
 		s := admissionregistrationv1.AllScopes
diff --git a/pkg/apis/admissionregistration/v1/register.go b/pkg/apis/admissionregistration/v1/register.go
@@ -21,6 +21,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
 )
 
+// GroupName is the group name used in this package
 const GroupName = "admissionregistration.k8s.io"
 
 // SchemeGroupVersion is group version used to register these objects
@@ -33,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &admissionregistrationv1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme handler to add items to the schema
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/admissionregistration/v1beta1/defaults.go b/pkg/apis/admissionregistration/v1beta1/defaults.go
@@ -27,6 +27,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error {
 	return RegisterDefaults(scheme)
 }
 
+// SetDefaults_ValidatingWebhook sets defaults for webhook validating
 func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1beta1.ValidatingWebhook) {
 	if obj.FailurePolicy == nil {
 		policy := admissionregistrationv1beta1.Ignore
@@ -59,6 +60,7 @@ func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1beta1.ValidatingW
 	}
 }
 
+// SetDefaults_MutatingWebhook sets defaults for webhook mutating
 func SetDefaults_MutatingWebhook(obj *admissionregistrationv1beta1.MutatingWebhook) {
 	if obj.FailurePolicy == nil {
 		policy := admissionregistrationv1beta1.Ignore
@@ -95,6 +97,7 @@ func SetDefaults_MutatingWebhook(obj *admissionregistrationv1beta1.MutatingWebho
 	}
 }
 
+// SetDefaults_Rule sets defaults for webhook rule
 func SetDefaults_Rule(obj *admissionregistrationv1beta1.Rule) {
 	if obj.Scope == nil {
 		s := admissionregistrationv1beta1.AllScopes
diff --git a/pkg/apis/admissionregistration/v1beta1/register.go b/pkg/apis/admissionregistration/v1beta1/register.go
@@ -21,6 +21,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
 )
 
+// GroupName is the group name used in this package
 const GroupName = "admissionregistration.k8s.io"
 
 // SchemeGroupVersion is group version used to register these objects
@@ -33,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &admissionregistrationv1beta1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme handler to add items to the schema
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/admissionregistration/validation/validation.go b/pkg/apis/admissionregistration/validation/validation.go
@@ -496,6 +496,7 @@ func validatingHasNoSideEffects(webhooks []admissionregistration.ValidatingWebho
 	return true
 }
 
+// ValidateValidatingWebhookConfigurationUpdate validates update of validating webhook configuration
 func ValidateValidatingWebhookConfigurationUpdate(newC, oldC *admissionregistration.ValidatingWebhookConfiguration, requestGV schema.GroupVersion) field.ErrorList {
 	return validateValidatingWebhookConfiguration(newC, validationOptions{
 		requireNoSideEffects:                    requireNoSideEffects(requestGV) && validatingHasNoSideEffects(oldC.Webhooks),
@@ -504,6 +505,7 @@ func ValidateValidatingWebhookConfigurationUpdate(newC, oldC *admissionregistrat
 	})
 }
 
+// ValidateMutatingWebhookConfigurationUpdate validates update of mutating webhook configuration
 func ValidateMutatingWebhookConfigurationUpdate(newC, oldC *admissionregistration.MutatingWebhookConfiguration, requestGV schema.GroupVersion) field.ErrorList {
 	return validateMutatingWebhookConfiguration(newC, validationOptions{
 		requireNoSideEffects:                    requireNoSideEffects(requestGV) && mutatingHasNoSideEffects(oldC.Webhooks),

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error {`
`27`	`27`	`return RegisterDefaults(scheme)`
`28`	`28`	`}`
`29`	`29`
	`30`	`+// SetDefaults_ValidatingWebhook sets defaults for webhook validating`
`30`	`31`	`func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1.ValidatingWebhook) {`
`31`	`32`	`if obj.FailurePolicy == nil {`
`32`	`33`	`policy := admissionregistrationv1.Fail`
`@@ -50,6 +51,7 @@ func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1.ValidatingWebhoo`
`50`	`51`	`}`
`51`	`52`	`}`
`52`	`53`
	`54`	`+// SetDefaults_MutatingWebhook sets defaults for webhook mutating`
`53`	`55`	`func SetDefaults_MutatingWebhook(obj *admissionregistrationv1.MutatingWebhook) {`
`54`	`56`	`if obj.FailurePolicy == nil {`
`55`	`57`	`policy := admissionregistrationv1.Fail`
`@@ -77,6 +79,7 @@ func SetDefaults_MutatingWebhook(obj *admissionregistrationv1.MutatingWebhook) {`
`77`	`79`	`}`
`78`	`80`	`}`
`79`	`81`
	`82`	`+// SetDefaults_Rule sets defaults for webhook rule`
`80`	`83`	`func SetDefaults_Rule(obj *admissionregistrationv1.Rule) {`
`81`	`84`	`if obj.Scope == nil {`
`82`	`85`	`s := admissionregistrationv1.AllScopes`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ import (`
`21`	`21`	`"k8s.io/apimachinery/pkg/runtime/schema"`
`22`	`22`	`)`
`23`	`23`
	`24`	`+// GroupName is the group name used in this package`
`24`	`25`	`const GroupName = "admissionregistration.k8s.io"`
`25`	`26`
`26`	`27`	`// SchemeGroupVersion is group version used to register these objects`
`@@ -33,7 +34,8 @@ func Resource(resource string) schema.GroupResource {`
`33`	`34`
`34`	`35`	`var (`
`35`	`36`	`localSchemeBuilder = &admissionregistrationv1.SchemeBuilder`
`36`		`- AddToScheme = localSchemeBuilder.AddToScheme`
	`37`	`+ // AddToScheme handler to add items to the schema`
	`38`	`+ AddToScheme = localSchemeBuilder.AddToScheme`
`37`	`39`	`)`
`38`	`40`
`39`	`41`	`func init() {`
Original file line number	Diff line number	Diff line change
`@@ -496,6 +496,7 @@ func validatingHasNoSideEffects(webhooks []admissionregistration.ValidatingWebho`
`496`	`496`	`return true`
`497`	`497`	`}`
`498`	`498`
	`499`	`+// ValidateValidatingWebhookConfigurationUpdate validates update of validating webhook configuration`
`499`	`500`	`func ValidateValidatingWebhookConfigurationUpdate(newC, oldC *admissionregistration.ValidatingWebhookConfiguration, requestGV schema.GroupVersion) field.ErrorList {`
`500`	`501`	`return validateValidatingWebhookConfiguration(newC, validationOptions{`
`501`	`502`	`requireNoSideEffects: requireNoSideEffects(requestGV) && validatingHasNoSideEffects(oldC.Webhooks),`
`@@ -504,6 +505,7 @@ func ValidateValidatingWebhookConfigurationUpdate(newC, oldC *admissionregistrat`
`504`	`505`	`})`
`505`	`506`	`}`
`506`	`507`
	`508`	`+// ValidateMutatingWebhookConfigurationUpdate validates update of mutating webhook configuration`
`507`	`509`	`func ValidateMutatingWebhookConfigurationUpdate(newC, oldC *admissionregistration.MutatingWebhookConfiguration, requestGV schema.GroupVersion) field.ErrorList {`
`508`	`510`	`return validateMutatingWebhookConfiguration(newC, validationOptions{`
`509`	`511`	`requireNoSideEffects: requireNoSideEffects(requestGV) && mutatingHasNoSideEffects(oldC.Webhooks),`