Fix VMSS cache content

ArchangelSDY · ArchangelSDY · commit ce3644ca593d · 2020-03-10T19:17:48.000+08:00
Using reference to a loop iterator variable is common mistake because it
takes different values in each loop iteration.
diff --git a/staging/src/k8s.io/legacy-cloud-providers/azure/azure_vmss_cache.go b/staging/src/k8s.io/legacy-cloud-providers/azure/azure_vmss_cache.go
@@ -73,7 +73,8 @@ func (ss *scaleSet) newVMSSCache() (*azcache.TimedCache, error) {
 				return nil, rerr.Error()
 			}
 
-			for _, scaleSet := range allScaleSets {
+			for i := range allScaleSets {
+				scaleSet := allScaleSets[i]
 				if scaleSet.Name == nil || *scaleSet.Name == "" {
 					klog.Warning("failed to get the name of VMSS")
 					continue

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,8 @@ func (ss scaleSet) newVMSSCache() (azcache.TimedCache, error) {`
`73`	`73`	`return nil, rerr.Error()`
`74`	`74`	`}`
`75`	`75`
`76`		`- for _, scaleSet := range allScaleSets {`
	`76`	`+ for i := range allScaleSets {`
	`77`	`+ scaleSet := allScaleSets[i]`
`77`	`78`	`if scaleSet.Name == nil \|\| *scaleSet.Name == "" {`
`78`	`79`	`klog.Warning("failed to get the name of VMSS")`
`79`	`80`	`continue`