Skip to content

Commit d532d50

Browse files
authored
Merge pull request kubernetes#63947 from jennybuckley/aggr-conf-test
Promote aggregator e2e test to conformance
2 parents 4b8ecd6 + 8101b86 commit d532d50

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

test/conformance/testdata/conformance.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
test/e2e/apimachinery/aggregator.go: "Should be able to support the 1.10 Sample API Server using the current Aggregator"
12
test/e2e/apimachinery/custom_resource_definition.go: "creating/deleting custom resource definition objects works"
23
test/e2e/apimachinery/garbage_collector.go: "should delete pods created by rc when not orphaning"
34
test/e2e/apimachinery/garbage_collector.go: "should orphan pods created by rc if delete options say so"

test/e2e/apimachinery/aggregator.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,12 @@ var _ = SIGDescribe("Aggregator", func() {
7272
aggrclient = f.AggregatorClient
7373
})
7474

75-
It("Should be able to support the 1.10 Sample API Server using the current Aggregator", func() {
76-
// Make sure the relevant provider supports Aggregator
77-
framework.SkipUnlessServerVersionGTE(serverAggregatorVersion, f.ClientSet.Discovery())
78-
framework.SkipUnlessProviderIs("gce", "gke")
79-
75+
/*
76+
Testname: aggregator-supports-the-sample-apiserver
77+
Description: Ensure that the sample-apiserver code from 1.10 and compiled against 1.10
78+
will work on the current Aggregator/API-Server.
79+
*/
80+
framework.ConformanceIt("Should be able to support the 1.10 Sample API Server using the current Aggregator", func() {
8081
// Testing a 1.10 version of the sample-apiserver
8182
TestSampleAPIServer(f, imageutils.GetE2EImage(imageutils.APIServer))
8283
})

0 commit comments

Comments
 (0)