Skip to content

Commit d6522e0

Browse files
committed
rename framework pkg with schedulerframework for all instances under pkg/kubelet
1 parent bed9b2f commit d6522e0

11 files changed

+36
-36
lines changed

pkg/kubelet/cm/container_manager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
3232
"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache"
3333
"k8s.io/kubernetes/pkg/kubelet/status"
34-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
34+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
3535

3636
"fmt"
3737
"strconv"
@@ -91,7 +91,7 @@ type ContainerManager interface {
9191
// Otherwise, it updates allocatableResource in nodeInfo if necessary,
9292
// to make sure it is at least equal to the pod's requested capacity for
9393
// any registered device plugin resource
94-
UpdatePluginResources(*framework.NodeInfo, *lifecycle.PodAdmitAttributes) error
94+
UpdatePluginResources(*schedulerframework.NodeInfo, *lifecycle.PodAdmitAttributes) error
9595

9696
InternalContainerLifecycle() InternalContainerLifecycle
9797

pkg/kubelet/cm/container_manager_linux.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ import (
6262
"k8s.io/kubernetes/pkg/kubelet/qos"
6363
"k8s.io/kubernetes/pkg/kubelet/stats/pidlimit"
6464
"k8s.io/kubernetes/pkg/kubelet/status"
65-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
65+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
6666
"k8s.io/kubernetes/pkg/util/oom"
6767
"k8s.io/kubernetes/pkg/util/procfs"
6868
utilsysctl "k8s.io/kubernetes/pkg/util/sysctl"
@@ -675,7 +675,7 @@ func (cm *containerManagerImpl) GetResources(pod *v1.Pod, container *v1.Containe
675675
return opts, nil
676676
}
677677

678-
func (cm *containerManagerImpl) UpdatePluginResources(node *framework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
678+
func (cm *containerManagerImpl) UpdatePluginResources(node *schedulerframework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
679679
return cm.deviceManager.UpdatePluginResources(node, attrs)
680680
}
681681

pkg/kubelet/cm/container_manager_stub.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
3131
"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache"
3232
"k8s.io/kubernetes/pkg/kubelet/status"
33-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
33+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
3434
)
3535

3636
type containerManagerStub struct {
@@ -97,7 +97,7 @@ func (cm *containerManagerStub) GetResources(pod *v1.Pod, container *v1.Containe
9797
return &kubecontainer.RunContainerOptions{}, nil
9898
}
9999

100-
func (cm *containerManagerStub) UpdatePluginResources(*framework.NodeInfo, *lifecycle.PodAdmitAttributes) error {
100+
func (cm *containerManagerStub) UpdatePluginResources(*schedulerframework.NodeInfo, *lifecycle.PodAdmitAttributes) error {
101101
return nil
102102
}
103103

pkg/kubelet/cm/container_manager_windows.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ import (
4242
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
4343
"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache"
4444
"k8s.io/kubernetes/pkg/kubelet/status"
45-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
45+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
4646
)
4747

4848
type containerManagerImpl struct {
@@ -165,7 +165,7 @@ func (cm *containerManagerImpl) GetResources(pod *v1.Pod, container *v1.Containe
165165
return &kubecontainer.RunContainerOptions{}, nil
166166
}
167167

168-
func (cm *containerManagerImpl) UpdatePluginResources(*framework.NodeInfo, *lifecycle.PodAdmitAttributes) error {
168+
func (cm *containerManagerImpl) UpdatePluginResources(*schedulerframework.NodeInfo, *lifecycle.PodAdmitAttributes) error {
169169
return nil
170170
}
171171

pkg/kubelet/cm/devicemanager/manager.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ import (
4848
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
4949
"k8s.io/kubernetes/pkg/kubelet/metrics"
5050
"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache"
51-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
51+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
5252
"k8s.io/kubernetes/pkg/util/selinux"
5353
)
5454

@@ -391,7 +391,7 @@ func (m *ManagerImpl) Allocate(pod *v1.Pod, container *v1.Container) error {
391391
}
392392

393393
// UpdatePluginResources updates node resources based on devices already allocated to pods.
394-
func (m *ManagerImpl) UpdatePluginResources(node *framework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
394+
func (m *ManagerImpl) UpdatePluginResources(node *schedulerframework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
395395
pod := attrs.Pod
396396

397397
m.mutex.Lock()
@@ -924,8 +924,8 @@ func (m *ManagerImpl) callPreStartContainerIfNeeded(podUID, contName, resource s
924924
// and if necessary, updates allocatableResource in nodeInfo to at least equal to
925925
// the allocated capacity. This allows pods that have already been scheduled on
926926
// the node to pass GeneralPredicates admission checking even upon device plugin failure.
927-
func (m *ManagerImpl) sanitizeNodeAllocatable(node *framework.NodeInfo) {
928-
var newAllocatableResource *framework.Resource
927+
func (m *ManagerImpl) sanitizeNodeAllocatable(node *schedulerframework.NodeInfo) {
928+
var newAllocatableResource *schedulerframework.Resource
929929
allocatableResource := node.Allocatable
930930
if allocatableResource.ScalarResources == nil {
931931
allocatableResource.ScalarResources = make(map[v1.ResourceName]int64)

pkg/kubelet/cm/devicemanager/manager_stub.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"k8s.io/kubernetes/pkg/kubelet/config"
2424
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
2525
"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache"
26-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
26+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
2727
)
2828

2929
// ManagerStub provides a simple stub implementation for the Device Manager.
@@ -50,7 +50,7 @@ func (h *ManagerStub) Allocate(pod *v1.Pod, container *v1.Container) error {
5050
}
5151

5252
// UpdatePluginResources simply returns nil.
53-
func (h *ManagerStub) UpdatePluginResources(node *framework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
53+
func (h *ManagerStub) UpdatePluginResources(node *schedulerframework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
5454
return nil
5555
}
5656

pkg/kubelet/cm/devicemanager/manager_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ import (
4242
"k8s.io/kubernetes/pkg/kubelet/config"
4343
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
4444
"k8s.io/kubernetes/pkg/kubelet/pluginmanager"
45-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
45+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
4646
)
4747

4848
const (
@@ -889,7 +889,7 @@ func TestUpdatePluginResources(t *testing.T) {
889889
},
890890
},
891891
}
892-
nodeInfo := &framework.NodeInfo{}
892+
nodeInfo := &schedulerframework.NodeInfo{}
893893
nodeInfo.SetNode(cachedNode)
894894

895895
testManager.UpdatePluginResources(nodeInfo, &lifecycle.PodAdmitAttributes{Pod: pod})

pkg/kubelet/cm/devicemanager/types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626
kubecontainer "k8s.io/kubernetes/pkg/kubelet/container"
2727
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
2828
"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache"
29-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
29+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
3030
)
3131

3232
// Manager manages all the Device Plugins running on a node.
@@ -44,7 +44,7 @@ type Manager interface {
4444
// UpdatePluginResources updates node resources based on devices already
4545
// allocated to pods. The node object is provided for the device manager to
4646
// update the node capacity to reflect the currently available devices.
47-
UpdatePluginResources(node *framework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error
47+
UpdatePluginResources(node *schedulerframework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error
4848

4949
// Stop stops the manager.
5050
Stop() error

pkg/kubelet/kubelet_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ import (
6767
kubetypes "k8s.io/kubernetes/pkg/kubelet/types"
6868
"k8s.io/kubernetes/pkg/kubelet/util/queue"
6969
kubeletvolume "k8s.io/kubernetes/pkg/kubelet/volumemanager"
70-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
70+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
7171
"k8s.io/kubernetes/pkg/volume"
7272
"k8s.io/kubernetes/pkg/volume/awsebs"
7373
"k8s.io/kubernetes/pkg/volume/azure_dd"
@@ -658,7 +658,7 @@ func TestHandlePluginResources(t *testing.T) {
658658
}
659659
kl.nodeLister = testNodeLister{nodes: nodes}
660660

661-
updatePluginResourcesFunc := func(node *framework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
661+
updatePluginResourcesFunc := func(node *schedulerframework.NodeInfo, attrs *lifecycle.PodAdmitAttributes) error {
662662
// Maps from resourceName to the value we use to set node.allocatableResource[resourceName].
663663
// A resource with invalid value (< 0) causes the function to return an error
664664
// to emulate resource Allocation failure.

pkg/kubelet/lifecycle/predicate.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ import (
2828
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodename"
2929
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodeports"
3030
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/noderesources"
31-
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
31+
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
3232
)
3333

3434
type getNodeAnyWayFuncType func() (*v1.Node, error)
3535

36-
type pluginResourceUpdateFuncType func(*framework.NodeInfo, *PodAdmitAttributes) error
36+
type pluginResourceUpdateFuncType func(*schedulerframework.NodeInfo, *PodAdmitAttributes) error
3737

3838
// AdmissionFailureHandler is an interface which defines how to deal with a failure to admit a pod.
3939
// This allows for the graceful handling of pod admission failure.
@@ -69,7 +69,7 @@ func (w *predicateAdmitHandler) Admit(attrs *PodAdmitAttributes) PodAdmitResult
6969
}
7070
admitPod := attrs.Pod
7171
pods := attrs.OtherPods
72-
nodeInfo := framework.NewNodeInfo(pods...)
72+
nodeInfo := schedulerframework.NewNodeInfo(pods...)
7373
nodeInfo.SetNode(node)
7474
// ensure the node has enough plugin resources for that required in pods
7575
if err = w.pluginResourceUpdateFunc(nodeInfo, attrs); err != nil {
@@ -155,7 +155,7 @@ func (w *predicateAdmitHandler) Admit(attrs *PodAdmitAttributes) PodAdmitResult
155155
}
156156
}
157157

158-
func removeMissingExtendedResources(pod *v1.Pod, nodeInfo *framework.NodeInfo) *v1.Pod {
158+
func removeMissingExtendedResources(pod *v1.Pod, nodeInfo *schedulerframework.NodeInfo) *v1.Pod {
159159
podCopy := pod.DeepCopy()
160160
for i, c := range pod.Spec.Containers {
161161
// We only handle requests in Requests but not Limits because the
@@ -219,7 +219,7 @@ func (e *PredicateFailureError) GetReason() string {
219219
}
220220

221221
// GeneralPredicates checks a group of predicates that the kubelet cares about.
222-
func GeneralPredicates(pod *v1.Pod, nodeInfo *framework.NodeInfo) ([]PredicateFailureReason, error) {
222+
func GeneralPredicates(pod *v1.Pod, nodeInfo *schedulerframework.NodeInfo) ([]PredicateFailureReason, error) {
223223
if nodeInfo.Node() == nil {
224224
return nil, fmt.Errorf("node not found")
225225
}

0 commit comments

Comments
 (0)