Skip to content

Commit d6f44b0

Browse files
authored
Merge pull request kubernetes#90278 from aojea/closewait
Deflake TCP Closewait e2e test
2 parents 4820b6c + 6efe6e1 commit d6f44b0

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

test/e2e/network/kube_proxy.go

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,9 @@ var kubeProxyE2eImage = imageutils.GetE2EImage(imageutils.Agnhost)
4444

4545
var _ = SIGDescribe("Network", func() {
4646
const (
47-
testDaemonHTTPPort = 11301
48-
testDaemonTCPPort = 11302
49-
deadlineTimeoutSeconds = 5
50-
postFinTimeoutSeconds = 15
47+
testDaemonHTTPPort = 11301
48+
testDaemonTCPPort = 11302
49+
postFinTimeoutSeconds = 30
5150
)
5251

5352
fr := framework.NewDefaultFramework("network")
@@ -81,8 +80,6 @@ var _ = SIGDescribe("Network", func() {
8180
nodeIP: ips[1],
8281
}
8382

84-
zero := int64(0)
85-
8683
// Create a pod to check the conntrack entries on the host node
8784
// It mounts the host /proc/net folder to be able to access
8885
// the nf_conntrack file with the host conntrack entries
@@ -101,7 +98,7 @@ var _ = SIGDescribe("Network", func() {
10198
{
10299
Name: "e2e-net-exec",
103100
Image: kubeProxyE2eImage,
104-
ImagePullPolicy: "Always",
101+
ImagePullPolicy: v1.PullIfNotPresent,
105102
Args: []string{"pause"},
106103
VolumeMounts: []v1.VolumeMount{
107104
{
@@ -125,7 +122,6 @@ var _ = SIGDescribe("Network", func() {
125122
},
126123
},
127124
},
128-
TerminationGracePeriodSeconds: &zero,
129125
},
130126
}
131127
fr.PodClient().CreateSync(hostExecPod)
@@ -152,19 +148,18 @@ var _ = SIGDescribe("Network", func() {
152148
{
153149
Name: "e2e-net-client",
154150
Image: kubeProxyE2eImage,
155-
ImagePullPolicy: "Always",
151+
ImagePullPolicy: v1.PullIfNotPresent,
156152
Args: []string{
157153
"net",
158154
"--runner", "nat-closewait-client",
159155
"--options",
160156
fmt.Sprintf(`{"RemoteAddr":"%v", "PostFinTimeoutSeconds":%v, "TimeoutSeconds":%v, "LeakConnection":true}`,
161157
net.JoinHostPort(serverNodeInfo.nodeIP, strconv.Itoa(testDaemonTCPPort)),
162158
postFinTimeoutSeconds,
163-
deadlineTimeoutSeconds),
159+
0),
164160
},
165161
},
166162
},
167-
TerminationGracePeriodSeconds: &zero,
168163
},
169164
}
170165

@@ -180,7 +175,7 @@ var _ = SIGDescribe("Network", func() {
180175
{
181176
Name: "e2e-net-server",
182177
Image: kubeProxyE2eImage,
183-
ImagePullPolicy: "Always",
178+
ImagePullPolicy: v1.PullIfNotPresent,
184179
Args: []string{
185180
"net",
186181
"--runner", "nat-closewait-server",
@@ -198,7 +193,6 @@ var _ = SIGDescribe("Network", func() {
198193
},
199194
},
200195
},
201-
TerminationGracePeriodSeconds: &zero,
202196
},
203197
}
204198

@@ -237,7 +231,7 @@ var _ = SIGDescribe("Network", func() {
237231
cmd := fmt.Sprintf("cat /rootfs/proc/net/nf_conntrack "+
238232
"| grep -m 1 'CLOSE_WAIT.*dst=%v.*dport=%v' ",
239233
ip, testDaemonTCPPort)
240-
if err := wait.PollImmediate(deadlineTimeoutSeconds, postFinTimeoutSeconds, func() (bool, error) {
234+
if err := wait.PollImmediate(1*time.Second, postFinTimeoutSeconds, func() (bool, error) {
241235
result, err := framework.RunHostCmd(fr.Namespace.Name, "e2e-net-exec", cmd)
242236
// retry if we can't obtain the conntrack entry
243237
if err != nil {

0 commit comments

Comments
 (0)