Skip to content

Commit d900746

Browse files
authored
Merge pull request kubernetes#80188 from davidz627/fix/migrateTest
Fix error shadowing error for createPDWithRetry so failures return actual error
2 parents fe04041 + 0974db4 commit d900746

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/e2e/framework/pv_util.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,8 +647,9 @@ func MakePersistentVolumeClaim(cfg PersistentVolumeClaimConfig, ns string) *v1.P
647647

648648
func createPDWithRetry(zone string) (string, error) {
649649
var err error
650+
var newDiskName string
650651
for start := time.Now(); time.Since(start) < pdRetryTimeout; time.Sleep(pdRetryPollTime) {
651-
newDiskName, err := createPD(zone)
652+
newDiskName, err = createPD(zone)
652653
if err != nil {
653654
e2elog.Logf("Couldn't create a new PD, sleeping 5 seconds: %v", err)
654655
continue

0 commit comments

Comments
 (0)