Skip to content

Commit d93999b

Browse files
authored
Merge pull request kubernetes#85302 from porridge/patch-2
Add support for GOBIN to generate-groups.sh.
2 parents 4c6bed6 + d931b84 commit d93999b

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

staging/src/k8s.io/code-generator/generate-groups.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ shift 4
5252
cd "$(dirname "${0}")"
5353
go install ./cmd/{defaulter-gen,client-gen,lister-gen,informer-gen,deepcopy-gen}
5454
)
55+
# Go installs the above commands to get installed in $GOBIN if defined, and $GOPATH/bin otherwise:
56+
GOBIN="$(go env GOBIN)"
57+
gobin="${GOBIN:-$(go env GOPATH)/bin}"
5558

5659
function codegen::join() { local IFS="$1"; shift; echo "$*"; }
5760

@@ -68,22 +71,22 @@ done
6871

6972
if [ "${GENS}" = "all" ] || grep -qw "deepcopy" <<<"${GENS}"; then
7073
echo "Generating deepcopy funcs"
71-
"${GOPATH}/bin/deepcopy-gen" --input-dirs "$(codegen::join , "${FQ_APIS[@]}")" -O zz_generated.deepcopy --bounding-dirs "${APIS_PKG}" "$@"
74+
"${gobin}/deepcopy-gen" --input-dirs "$(codegen::join , "${FQ_APIS[@]}")" -O zz_generated.deepcopy --bounding-dirs "${APIS_PKG}" "$@"
7275
fi
7376

7477
if [ "${GENS}" = "all" ] || grep -qw "client" <<<"${GENS}"; then
7578
echo "Generating clientset for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}"
76-
"${GOPATH}/bin/client-gen" --clientset-name "${CLIENTSET_NAME_VERSIONED:-versioned}" --input-base "" --input "$(codegen::join , "${FQ_APIS[@]}")" --output-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}" "$@"
79+
"${gobin}/client-gen" --clientset-name "${CLIENTSET_NAME_VERSIONED:-versioned}" --input-base "" --input "$(codegen::join , "${FQ_APIS[@]}")" --output-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}" "$@"
7780
fi
7881

7982
if [ "${GENS}" = "all" ] || grep -qw "lister" <<<"${GENS}"; then
8083
echo "Generating listers for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/listers"
81-
"${GOPATH}/bin/lister-gen" --input-dirs "$(codegen::join , "${FQ_APIS[@]}")" --output-package "${OUTPUT_PKG}/listers" "$@"
84+
"${gobin}/lister-gen" --input-dirs "$(codegen::join , "${FQ_APIS[@]}")" --output-package "${OUTPUT_PKG}/listers" "$@"
8285
fi
8386

8487
if [ "${GENS}" = "all" ] || grep -qw "informer" <<<"${GENS}"; then
8588
echo "Generating informers for ${GROUPS_WITH_VERSIONS} at ${OUTPUT_PKG}/informers"
86-
"${GOPATH}/bin/informer-gen" \
89+
"${gobin}/informer-gen" \
8790
--input-dirs "$(codegen::join , "${FQ_APIS[@]}")" \
8891
--versioned-clientset-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME:-clientset}/${CLIENTSET_NAME_VERSIONED:-versioned}" \
8992
--listers-package "${OUTPUT_PKG}/listers" \

0 commit comments

Comments
 (0)