Skip to content

Commit d964569

Browse files
author
Kenichi Omichi
committed
nit: Fix invokeStaleDummyVMTestWithStoragePolicy()
There were nits in invokeStaleDummyVMTestWithStoragePolicy() like - The error message didn't contain necessary space - IsVMPresent() can return an error, but lack of the error handling - IsVMPresent() returns true/false, but didn't use ExpectEqual() and less code readability This fixes those things.
1 parent 3c31a00 commit d964569

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/e2e/storage/vsphere/vsphere_volume_vsan_policy.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,9 @@ func invokeStaleDummyVMTestWithStoragePolicy(client clientset.Interface, masterN
335335
fnvHash := fnv.New32a()
336336
fnvHash.Write([]byte(vmName))
337337
dummyVMFullName := dummyVMPrefixName + "-" + fmt.Sprint(fnvHash.Sum32())
338-
errorMsg := "Dummy VM - " + vmName + "is still present. Failing the test.."
338+
errorMsg := "Dummy VM - " + vmName + " is still present. Failing the test.."
339339
nodeInfo := TestContext.NodeMapper.GetNodeInfo(masterNode)
340-
isVMPresentFlag, _ := nodeInfo.VSphere.IsVMPresent(dummyVMFullName, nodeInfo.DataCenterRef)
341-
framework.ExpectNotEqual(isVMPresentFlag, true, errorMsg)
340+
isVMPresentFlag, err := nodeInfo.VSphere.IsVMPresent(dummyVMFullName, nodeInfo.DataCenterRef)
341+
framework.ExpectNoError(err)
342+
framework.ExpectEqual(isVMPresentFlag, false, errorMsg)
342343
}

0 commit comments

Comments
 (0)