Merge pull request kubernetes#93587 from liggitt/daemonset-test-name

k8s-ci-robot · web-flow · commit d9789c4fa3ea · 2020-08-28T06:37:40.000-07:00
Clean up daemonset test names
diff --git a/test/integration/daemonset/daemonset_test.go b/test/integration/daemonset/daemonset_test.go
@@ -416,7 +416,7 @@ func updateDS(t *testing.T, dsClient appstyped.DaemonSetInterface, dsName string
 
 func forEachStrategy(t *testing.T, tf func(t *testing.T, strategy *apps.DaemonSetUpdateStrategy)) {
 	for _, strategy := range updateStrategies() {
-		t.Run(fmt.Sprintf("%s (%v)", t.Name(), strategy),
+		t.Run(fmt.Sprintf("%s_%s", t.Name(), strategy.Type),
 			func(tt *testing.T) { tf(tt, strategy) })
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ func updateDS(t *testing.T, dsClient appstyped.DaemonSetInterface, dsName string`
`416`	`416`
`417`	`417`	`func forEachStrategy(t testing.T, tf func(t testing.T, strategy *apps.DaemonSetUpdateStrategy)) {`
`418`	`418`	`for _, strategy := range updateStrategies() {`
`419`		`- t.Run(fmt.Sprintf("%s (%v)", t.Name(), strategy),`
	`419`	`+ t.Run(fmt.Sprintf("%s_%s", t.Name(), strategy.Type),`
`420`	`420`	`func(tt *testing.T) { tf(tt, strategy) })`
`421`	`421`	`}`
`422`	`422`	`}`