Skip to content

Commit daa27c9

Browse files
authored
Clarify behavior of publishNotReadyAddresses (kubernetes#90783)
* Clarify behavior of publishNotReadyAddresses * gen docs after clarifying publishNotReadyAddresses
1 parent b67e7d6 commit daa27c9

File tree

5 files changed

+26
-20
lines changed

5 files changed

+26
-20
lines changed

api/openapi-spec/swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/core/types.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3513,12 +3513,14 @@ type ServiceSpec struct {
35133513
// +optional
35143514
HealthCheckNodePort int32
35153515

3516-
// publishNotReadyAddresses, when set to true, indicates that DNS implementations
3517-
// must publish the notReadyAddresses of subsets for the Endpoints associated with
3518-
// the Service. The default value is false.
3519-
// The primary use case for setting this field is to use a StatefulSet's Headless Service
3520-
// to propagate SRV records for its Pods without respect to their readiness for purpose
3521-
// of peer discovery.
3516+
// publishNotReadyAddresses indicates that any agent which deals with endpoints for this
3517+
// Service should disregard any indications of ready/not-ready.
3518+
// The primary use case for setting this field is for a StatefulSet's Headless Service to
3519+
// propagate SRV DNS records for its Pods for the purpose of peer discovery.
3520+
// The Kubernetes controllers that generate Endpoints and EndpointSlice resources for
3521+
// Services interpret this to mean that all endpoints are considered "ready" even if the
3522+
// Pods themselves are not. Agents which consume only Kubernetes generated endpoints
3523+
// through the Endpoints or EndpointSlice resources can safely assume this behavior.
35223524
// +optional
35233525
PublishNotReadyAddresses bool
35243526

staging/src/k8s.io/api/core/v1/generated.proto

Lines changed: 8 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/core/v1/types.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3978,12 +3978,14 @@ type ServiceSpec struct {
39783978
// +optional
39793979
HealthCheckNodePort int32 `json:"healthCheckNodePort,omitempty" protobuf:"bytes,12,opt,name=healthCheckNodePort"`
39803980

3981-
// publishNotReadyAddresses, when set to true, indicates that DNS implementations
3982-
// must publish the notReadyAddresses of subsets for the Endpoints associated with
3983-
// the Service. The default value is false.
3984-
// The primary use case for setting this field is to use a StatefulSet's Headless Service
3985-
// to propagate SRV records for its Pods without respect to their readiness for purpose
3986-
// of peer discovery.
3981+
// publishNotReadyAddresses indicates that any agent which deals with endpoints for this
3982+
// Service should disregard any indications of ready/not-ready.
3983+
// The primary use case for setting this field is for a StatefulSet's Headless Service to
3984+
// propagate SRV DNS records for its Pods for the purpose of peer discovery.
3985+
// The Kubernetes controllers that generate Endpoints and EndpointSlice resources for
3986+
// Services interpret this to mean that all endpoints are considered "ready" even if the
3987+
// Pods themselves are not. Agents which consume only Kubernetes generated endpoints
3988+
// through the Endpoints or EndpointSlice resources can safely assume this behavior.
39873989
// +optional
39883990
PublishNotReadyAddresses bool `json:"publishNotReadyAddresses,omitempty" protobuf:"varint,13,opt,name=publishNotReadyAddresses"`
39893991

staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)