Merge pull request kubernetes#91499 from lo24/intf-fix

k8s-ci-robot · web-flow · commit dcdeed97cd86 · 2020-06-30T02:52:05.000-07:00
fix a regression that TestValidateNodeIPParam never actually works
diff --git a/pkg/kubelet/kubelet_node_status_test.go b/pkg/kubelet/kubelet_node_status_test.go
@@ -2151,7 +2151,7 @@ func TestValidateNodeIPParam(t *testing.T) {
 			ip = v.IP
 		}
 		if ip.IsLoopback() || ip.IsLinkLocalUnicast() {
-			break
+			continue
 		}
 		successTest := test{
 			nodeIP:   ip.String(),

Original file line number	Diff line number	Diff line change
`@@ -2151,7 +2151,7 @@ func TestValidateNodeIPParam(t *testing.T) {`
`2151`	`2151`	`ip = v.IP`
`2152`	`2152`	`}`
`2153`	`2153`	`if ip.IsLoopback() \|\| ip.IsLinkLocalUnicast() {`
`2154`		`- break`
	`2154`	`+ continue`
`2155`	`2155`	`}`
`2156`	`2156`	`successTest := test{`
`2157`	`2157`	`nodeIP: ip.String(),`