Skip to content

Commit df58c04

Browse files
committed
metaproxier logging for endpoints ipfamily
The kube-proxy metaproxier implementations tries to get the IPFamily from the endpoints, but if the endpoints doesn't contains an IP address it logs a Warning. This causes that services without endpoints keep flooding the logs with warnings. We log this errors with a level of Verbosity of 4 instead of a Warning
1 parent 23d9ffd commit df58c04

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

pkg/proxy/metaproxier/BUILD

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
load("@io_bazel_rules_go//go:def.bzl", "go_library")
3+
load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
44

55
go_library(
66
name = "go_default_library",
@@ -28,3 +28,10 @@ filegroup(
2828
srcs = [":package-srcs"],
2929
tags = ["automanaged"],
3030
)
31+
32+
go_test(
33+
name = "go_default_test",
34+
srcs = ["meta_proxier_test.go"],
35+
embed = [":go_default_library"],
36+
deps = ["//staging/src/k8s.io/api/core/v1:go_default_library"],
37+
)

pkg/proxy/metaproxier/meta_proxier.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ func (proxier *metaProxier) OnServiceSynced() {
103103
func (proxier *metaProxier) OnEndpointsAdd(endpoints *v1.Endpoints) {
104104
ipFamily, err := endpointsIPFamily(endpoints)
105105
if err != nil {
106-
klog.Warningf("failed to add endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err)
106+
klog.V(4).Infof("failed to add endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err)
107107
return
108108
}
109109
if *ipFamily == v1.IPv4Protocol {
@@ -118,7 +118,7 @@ func (proxier *metaProxier) OnEndpointsAdd(endpoints *v1.Endpoints) {
118118
func (proxier *metaProxier) OnEndpointsUpdate(oldEndpoints, endpoints *v1.Endpoints) {
119119
ipFamily, err := endpointsIPFamily(endpoints)
120120
if err != nil {
121-
klog.Warningf("failed to update endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err)
121+
klog.V(4).Infof("failed to update endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err)
122122
return
123123
}
124124

@@ -134,7 +134,7 @@ func (proxier *metaProxier) OnEndpointsUpdate(oldEndpoints, endpoints *v1.Endpoi
134134
func (proxier *metaProxier) OnEndpointsDelete(endpoints *v1.Endpoints) {
135135
ipFamily, err := endpointsIPFamily(endpoints)
136136
if err != nil {
137-
klog.Warningf("failed to delete endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err)
137+
klog.V(4).Infof("failed to delete endpoints %s/%s with error %v", endpoints.ObjectMeta.Namespace, endpoints.ObjectMeta.Name, err)
138138
return
139139
}
140140

0 commit comments

Comments
 (0)