Skip to content

Commit dfb6993

Browse files
authored
Merge pull request kubernetes#89182 from dims/just-use-runtime-numcpu
Just use runtime.NumCPU on windows
2 parents fe459b3 + 9668040 commit dfb6993

File tree

17 files changed

+5
-721
lines changed

17 files changed

+5
-721
lines changed

pkg/kubelet/dockershim/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ go_library(
7878
"//pkg/kubelet/apis:go_default_library",
7979
"//pkg/kubelet/winstats:go_default_library",
8080
"//vendor/github.com/Microsoft/hcsshim:go_default_library",
81-
"//vendor/github.com/docker/docker/pkg/sysinfo:go_default_library",
8281
"//vendor/golang.org/x/sys/windows/registry:go_default_library",
8382
],
8483
"//conditions:default": [],

pkg/kubelet/dockershim/helpers_windows.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ package dockershim
2020

2121
import (
2222
"os"
23+
"runtime"
2324

2425
"github.com/blang/semver"
2526
dockertypes "github.com/docker/docker/api/types"
2627
dockercontainer "github.com/docker/docker/api/types/container"
2728
dockerfilters "github.com/docker/docker/api/types/filters"
28-
"github.com/docker/docker/pkg/sysinfo"
2929
"k8s.io/klog"
3030

3131
runtimeapi "k8s.io/cri-api/pkg/apis/runtime/v1alpha2"
@@ -75,7 +75,7 @@ func (ds *dockerService) updateCreateConfig(
7575
Memory: rOpts.MemoryLimitInBytes,
7676
CPUShares: rOpts.CpuShares,
7777
CPUCount: rOpts.CpuCount,
78-
NanoCPUs: rOpts.CpuMaximum * int64(sysinfo.NumCPU()) * (1e9 / 10000),
78+
NanoCPUs: rOpts.CpuMaximum * int64(runtime.NumCPU()) * (1e9 / 10000),
7979
}
8080
}
8181

pkg/kubelet/kuberuntime/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ go_library(
8383
],
8484
"@io_bazel_rules_go//go/platform:windows": [
8585
"//pkg/kubelet/apis:go_default_library",
86-
"//vendor/github.com/docker/docker/pkg/sysinfo:go_default_library",
8786
],
8887
"//conditions:default": [],
8988
}),

pkg/kubelet/kuberuntime/kuberuntime_container_windows.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ package kuberuntime
2020

2121
import (
2222
"fmt"
23-
24-
"github.com/docker/docker/pkg/sysinfo"
23+
"runtime"
2524

2625
"k8s.io/api/core/v1"
2726
utilfeature "k8s.io/apiserver/pkg/util/feature"
@@ -85,7 +84,7 @@ func (m *kubeGenericRuntimeManager) generateWindowsContainerConfig(container *v1
8584
// https://github.com/opencontainers/runtime-spec/blob/ad53dcdc39f1f7f7472b10aa0a45648fe4865496/config-windows.md#cpu
8685
// If both CpuWeight and CpuMaximum are set - ContainerD catches this invalid case and returns an error instead.
8786

88-
cpuMaximum := 10000 * cpuLimit.MilliValue() / int64(sysinfo.NumCPU()) / 1000
87+
cpuMaximum := 10000 * cpuLimit.MilliValue() / int64(runtime.NumCPU()) / 1000
8988

9089
// TODO: This should be reviewed or removed once Hyper-V support is implemented with CRI-ContainerD
9190
// in a future release. cpuCount may or may not be required if cpuMaximum is set.

vendor/BUILD

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,8 @@ filegroup(
116116
"//vendor/github.com/docker/docker/errdefs:all-srcs",
117117
"//vendor/github.com/docker/docker/pkg/jsonmessage:all-srcs",
118118
"//vendor/github.com/docker/docker/pkg/mount:all-srcs",
119-
"//vendor/github.com/docker/docker/pkg/parsers:all-srcs",
119+
"//vendor/github.com/docker/docker/pkg/parsers/operatingsystem:all-srcs",
120120
"//vendor/github.com/docker/docker/pkg/stdcopy:all-srcs",
121-
"//vendor/github.com/docker/docker/pkg/sysinfo:all-srcs",
122121
"//vendor/github.com/docker/docker/pkg/term:all-srcs",
123122
"//vendor/github.com/docker/go-connections/nat:all-srcs",
124123
"//vendor/github.com/docker/go-connections/sockets:all-srcs",

vendor/github.com/docker/docker/pkg/parsers/BUILD

Lines changed: 0 additions & 26 deletions
This file was deleted.

vendor/github.com/docker/docker/pkg/parsers/parsers.go

Lines changed: 0 additions & 97 deletions
This file was deleted.

vendor/github.com/docker/docker/pkg/sysinfo/BUILD

Lines changed: 0 additions & 49 deletions
This file was deleted.

vendor/github.com/docker/docker/pkg/sysinfo/README.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

vendor/github.com/docker/docker/pkg/sysinfo/numcpu.go

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)