Skip to content

Commit e03c775

Browse files
authored
Merge pull request kubernetes#89213 from tanjunchen/cleanup20200318-003
e2e/framework : pods.go remove direct imports to k8s.io/kubernetes/pkg/
2 parents a75ee74 + 27e133a commit e03c775

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

test/e2e/framework/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ go_library(
2828
"//pkg/controller:go_default_library",
2929
"//pkg/kubelet/apis/config:go_default_library",
3030
"//pkg/kubelet/apis/stats/v1alpha1:go_default_library",
31-
"//pkg/kubelet/events:go_default_library",
32-
"//pkg/kubelet/sysctl:go_default_library",
3331
"//staging/src/k8s.io/api/apps/v1:go_default_library",
3432
"//staging/src/k8s.io/api/core/v1:go_default_library",
3533
"//staging/src/k8s.io/api/policy/v1beta1:go_default_library",

test/e2e/framework/pods.go

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ import (
3232
"k8s.io/client-go/kubernetes/scheme"
3333
v1core "k8s.io/client-go/kubernetes/typed/core/v1"
3434
"k8s.io/kubectl/pkg/util/podutils"
35-
"k8s.io/kubernetes/pkg/kubelet/events"
36-
"k8s.io/kubernetes/pkg/kubelet/sysctl"
3735

3836
"github.com/onsi/ginkgo"
3937
"github.com/onsi/gomega"
@@ -42,8 +40,22 @@ import (
4240
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
4341
)
4442

45-
// DefaultPodDeletionTimeout is the default timeout for deleting pod
46-
const DefaultPodDeletionTimeout = 3 * time.Minute
43+
const (
44+
// DefaultPodDeletionTimeout is the default timeout for deleting pod
45+
DefaultPodDeletionTimeout = 3 * time.Minute
46+
47+
// the status of container event, copied from k8s.io/kubernetes/pkg/kubelet/events
48+
killingContainer = "Killing"
49+
50+
// the status of container event, copied from k8s.io/kubernetes/pkg/kubelet/events
51+
failedToCreateContainer = "Failed"
52+
53+
// the status of container event, copied from k8s.io/kubernetes/pkg/kubelet/events
54+
startedContainer = "Started"
55+
56+
// it is copied from k8s.io/kubernetes/pkg/kubelet/sysctl
57+
forbiddenReason = "SysctlForbidden"
58+
)
4759

4860
// ImageWhiteList is the images used in the current test suite. It should be initialized in test suite and
4961
// the images in the white list should be pre-pulled in the test suite. Currently, this is only used by
@@ -227,10 +239,10 @@ func (c *PodClient) WaitForErrorEventOrSuccess(pod *v1.Pod) (*v1.Event, error) {
227239
}
228240
for _, e := range evnts.Items {
229241
switch e.Reason {
230-
case events.KillingContainer, events.FailedToCreateContainer, sysctl.ForbiddenReason:
242+
case killingContainer, failedToCreateContainer, forbiddenReason:
231243
ev = &e
232244
return true, nil
233-
case events.StartedContainer:
245+
case startedContainer:
234246
return true, nil
235247
default:
236248
// ignore all other errors

0 commit comments

Comments
 (0)