Skip to content

Commit e53a952

Browse files
authored
Merge pull request kubernetes#82283 from ahmad-diaa/fix-field-types-in-scheduler-api-types
Migrate scheduler api types to sized integers
2 parents 21db9c2 + 801cc54 commit e53a952

22 files changed

+75
-73
lines changed

pkg/scheduler/algorithm/priorities/even_pods_spread.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ func CalculateEvenPodsSpreadPriority(pod *v1.Pod, nodeNameToInfo map[string]*sch
176176
// debugging purpose: print the value for each node
177177
// score must be pointer here, otherwise it's always 0
178178
if klog.V(10) {
179-
defer func(score *int, nodeName string) {
179+
defer func(score *int64, nodeName string) {
180180
klog.Infof("%v -> %v: EvenPodsSpreadPriority, Score: (%d)", pod.Name, nodeName, *score)
181181
}(&result[i].Score, node.Name)
182182
}
@@ -190,7 +190,7 @@ func CalculateEvenPodsSpreadPriority(pod *v1.Pod, nodeNameToInfo map[string]*sch
190190
continue
191191
}
192192
fScore := float64(schedulerapi.MaxPriority) * (float64(total-t.nodeNameToPodCounts[node.Name]) / float64(maxMinDiff))
193-
result[i].Score = int(fScore)
193+
result[i].Score = int64(fScore)
194194
}
195195

196196
return result, nil

pkg/scheduler/algorithm/priorities/image_locality.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func ImageLocalityPriorityMap(pod *v1.Pod, meta interface{}, nodeInfo *scheduler
5555

5656
return schedulerapi.HostPriority{
5757
Host: node.Name,
58-
Score: score,
58+
Score: int64(score),
5959
}, nil
6060
}
6161

pkg/scheduler/algorithm/priorities/interpod_affinity.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ func (ipa *InterPodAffinity) CalculateInterPodAffinityPriority(pod *v1.Pod, node
236236
if maxMinDiff > 0 && pm.counts[node.Name] != nil {
237237
fScore = float64(schedulerapi.MaxPriority) * (float64(*pm.counts[node.Name]-minCount) / float64(maxCount-minCount))
238238
}
239-
result = append(result, schedulerapi.HostPriority{Host: node.Name, Score: int(fScore)})
239+
result = append(result, schedulerapi.HostPriority{Host: node.Name, Score: int64(fScore)})
240240
if klog.V(10) {
241241
klog.Infof("%v -> %v: InterPodAffinityPriority, Score: (%d)", pod.Name, node.Name, int(fScore))
242242
}

pkg/scheduler/algorithm/priorities/node_affinity.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func CalculateNodeAffinityPriorityMap(pod *v1.Pod, meta interface{}, nodeInfo *s
6969

7070
return schedulerapi.HostPriority{
7171
Host: node.Name,
72-
Score: int(count),
72+
Score: int64(count),
7373
}, nil
7474
}
7575

pkg/scheduler/algorithm/priorities/node_label.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,6 @@ func (n *NodeLabelPrioritizer) CalculateNodeLabelPriorityMap(pod *v1.Pod, meta i
5656
}
5757
return schedulerapi.HostPriority{
5858
Host: node.Name,
59-
Score: score,
59+
Score: int64(score),
6060
}, nil
6161
}

pkg/scheduler/algorithm/priorities/reduce.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ import (
2525
// NormalizeReduce generates a PriorityReduceFunction that can normalize the result
2626
// scores to [0, maxPriority]. If reverse is set to true, it reverses the scores by
2727
// subtracting it from maxPriority.
28-
func NormalizeReduce(maxPriority int, reverse bool) PriorityReduceFunction {
28+
func NormalizeReduce(maxPriority int64, reverse bool) PriorityReduceFunction {
2929
return func(
3030
_ *v1.Pod,
3131
_ interface{},
3232
_ map[string]*schedulernodeinfo.NodeInfo,
3333
result schedulerapi.HostPriorityList) error {
3434

35-
var maxCount int
35+
var maxCount int64
3636
for i := range result {
3737
if result[i].Score > maxCount {
3838
maxCount = result[i].Score

pkg/scheduler/algorithm/priorities/resource_allocation.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func (r *ResourceAllocationPriority) PriorityMap(
9292

9393
return schedulerapi.HostPriority{
9494
Host: node.Name,
95-
Score: int(score),
95+
Score: score,
9696
}, nil
9797
}
9898

pkg/scheduler/algorithm/priorities/resource_limits.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func ResourceLimitsPriorityMap(pod *v1.Pod, meta interface{}, nodeInfo *schedule
5454
cpuScore := computeScore(podLimits.MilliCPU, allocatableResources.MilliCPU)
5555
memScore := computeScore(podLimits.Memory, allocatableResources.Memory)
5656

57-
score := int(0)
57+
score := int64(0)
5858
if cpuScore == 1 || memScore == 1 {
5959
score = 1
6060
}

pkg/scheduler/algorithm/priorities/selector_spreading.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,15 @@ func (s *SelectorSpread) CalculateSpreadPriorityMap(pod *v1.Pod, meta interface{
8080
if len(selectors) == 0 {
8181
return schedulerapi.HostPriority{
8282
Host: node.Name,
83-
Score: int(0),
83+
Score: 0,
8484
}, nil
8585
}
8686

8787
count := countMatchingPods(pod.Namespace, selectors, nodeInfo)
8888

8989
return schedulerapi.HostPriority{
9090
Host: node.Name,
91-
Score: count,
91+
Score: int64(count),
9292
}, nil
9393
}
9494

@@ -97,9 +97,9 @@ func (s *SelectorSpread) CalculateSpreadPriorityMap(pod *v1.Pod, meta interface{
9797
// where zone information is included on the nodes, it favors nodes
9898
// in zones with fewer existing matching pods.
9999
func (s *SelectorSpread) CalculateSpreadPriorityReduce(pod *v1.Pod, meta interface{}, nodeNameToInfo map[string]*schedulernodeinfo.NodeInfo, result schedulerapi.HostPriorityList) error {
100-
countsByZone := make(map[string]int, 10)
101-
maxCountByZone := int(0)
102-
maxCountByNodeName := int(0)
100+
countsByZone := make(map[string]int64, 10)
101+
maxCountByZone := int64(0)
102+
maxCountByNodeName := int64(0)
103103

104104
for i := range result {
105105
if result[i].Score > maxCountByNodeName {
@@ -141,10 +141,10 @@ func (s *SelectorSpread) CalculateSpreadPriorityReduce(pod *v1.Pod, meta interfa
141141
fScore = (fScore * (1.0 - zoneWeighting)) + (zoneWeighting * zoneScore)
142142
}
143143
}
144-
result[i].Score = int(fScore)
144+
result[i].Score = int64(fScore)
145145
if klog.V(10) {
146146
klog.Infof(
147-
"%v -> %v: SelectorSpreadPriority, Score: (%d)", pod.Name, result[i].Host, int(fScore),
147+
"%v -> %v: SelectorSpreadPriority, Score: (%d)", pod.Name, result[i].Host, int64(fScore),
148148
)
149149
}
150150
}
@@ -232,16 +232,16 @@ func (s *ServiceAntiAffinity) CalculateAntiAffinityPriorityMap(pod *v1.Pod, meta
232232

233233
return schedulerapi.HostPriority{
234234
Host: node.Name,
235-
Score: score,
235+
Score: int64(score),
236236
}, nil
237237
}
238238

239239
// CalculateAntiAffinityPriorityReduce computes each node score with the same value for a particular label.
240240
// The label to be considered is provided to the struct (ServiceAntiAffinity).
241241
func (s *ServiceAntiAffinity) CalculateAntiAffinityPriorityReduce(pod *v1.Pod, meta interface{}, nodeNameToInfo map[string]*schedulernodeinfo.NodeInfo, result schedulerapi.HostPriorityList) error {
242-
var numServicePods int
242+
var numServicePods int64
243243
var label string
244-
podCounts := map[string]int{}
244+
podCounts := map[string]int64{}
245245
labelNodesStatus := map[string]string{}
246246
maxPriorityFloat64 := float64(schedulerapi.MaxPriority)
247247

@@ -261,7 +261,7 @@ func (s *ServiceAntiAffinity) CalculateAntiAffinityPriorityReduce(pod *v1.Pod, m
261261
label, ok := labelNodesStatus[hostPriority.Host]
262262
if !ok {
263263
result[i].Host = hostPriority.Host
264-
result[i].Score = int(0)
264+
result[i].Score = 0
265265
continue
266266
}
267267
// initializing to the default/max node score of maxPriority
@@ -270,7 +270,7 @@ func (s *ServiceAntiAffinity) CalculateAntiAffinityPriorityReduce(pod *v1.Pod, m
270270
fScore = maxPriorityFloat64 * (float64(numServicePods-podCounts[label]) / float64(numServicePods))
271271
}
272272
result[i].Host = hostPriority.Host
273-
result[i].Score = int(fScore)
273+
result[i].Score = int64(fScore)
274274
}
275275

276276
return nil

pkg/scheduler/algorithm/priorities/taint_toleration.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func ComputeTaintTolerationPriorityMap(pod *v1.Pod, meta interface{}, nodeInfo *
6868

6969
return schedulerapi.HostPriority{
7070
Host: node.Name,
71-
Score: countIntolerableTaintsPreferNoSchedule(node.Spec.Taints, tolerationsPreferNoSchedule),
71+
Score: int64(countIntolerableTaintsPreferNoSchedule(node.Spec.Taints, tolerationsPreferNoSchedule)),
7272
}, nil
7373
}
7474

0 commit comments

Comments
 (0)