Skip to content

Commit e6b6e40

Browse files
authored
Merge pull request kubernetes#81601 from yastij/remove-keyfun
use DeletionHandlingMetaNamespaceKeyFunc from client-go in service_controller
2 parents e102d57 + 3fe7a57 commit e6b6e40

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

pkg/controller/service/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ go_library(
1616
importpath = "k8s.io/kubernetes/pkg/controller/service",
1717
deps = [
1818
"//pkg/apis/core/v1/helper:go_default_library",
19-
"//pkg/controller:go_default_library",
2019
"//pkg/util/metrics:go_default_library",
2120
"//staging/src/k8s.io/api/core/v1:go_default_library",
2221
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",

pkg/controller/service/service_controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import (
4242
servicehelper "k8s.io/cloud-provider/service/helpers"
4343
"k8s.io/klog"
4444
v1helper "k8s.io/kubernetes/pkg/apis/core/v1/helper"
45-
"k8s.io/kubernetes/pkg/controller"
4645
"k8s.io/kubernetes/pkg/util/metrics"
4746
)
4847

@@ -195,7 +194,7 @@ func New(
195194

196195
// obj could be an *v1.Service, or a DeletionFinalStateUnknown marker item.
197196
func (s *ServiceController) enqueueService(obj interface{}) {
198-
key, err := controller.KeyFunc(obj)
197+
key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
199198
if err != nil {
200199
runtime.HandleError(fmt.Errorf("couldn't get key for object %#v: %v", obj, err))
201200
return

0 commit comments

Comments
 (0)