Skip to content

Commit e74ad38

Browse files
authored
Merge pull request kubernetes#89013 from dims/copy-jsonlog-from-docker/docker-locally
Copy jsonlog from docker/docker locally
2 parents 2c8ef3b + 825f99c commit e74ad38

File tree

8 files changed

+13
-204
lines changed

8 files changed

+13
-204
lines changed

pkg/kubelet/kuberuntime/logs/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ go_library(
1010
"//staging/src/k8s.io/api/core/v1:go_default_library",
1111
"//staging/src/k8s.io/cri-api/pkg/apis:go_default_library",
1212
"//staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2:go_default_library",
13-
"//vendor/github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog:go_default_library",
1413
"//vendor/github.com/fsnotify/fsnotify:go_default_library",
1514
"//vendor/k8s.io/klog:go_default_library",
1615
],

pkg/kubelet/kuberuntime/logs/logs.go

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import (
2929
"path/filepath"
3030
"time"
3131

32-
"github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog"
3332
"github.com/fsnotify/fsnotify"
3433
"k8s.io/klog"
3534

@@ -165,13 +164,24 @@ func parseCRILog(log []byte, msg *logMessage) error {
165164
return nil
166165
}
167166

167+
// jsonLog is a log message, typically a single entry from a given log stream.
168+
// since the data structure is originally from docker, we should be careful to
169+
// with any changes to jsonLog
170+
type jsonLog struct {
171+
// Log is the log message
172+
Log string `json:"log,omitempty"`
173+
// Stream is the log source
174+
Stream string `json:"stream,omitempty"`
175+
// Created is the created timestamp of log
176+
Created time.Time `json:"time"`
177+
}
178+
168179
// parseDockerJSONLog parses logs in Docker JSON log format. Docker JSON log format
169180
// example:
170181
// {"log":"content 1","stream":"stdout","time":"2016-10-20T18:39:20.57606443Z"}
171182
// {"log":"content 2","stream":"stderr","time":"2016-10-20T18:39:20.57606444Z"}
172183
func parseDockerJSONLog(log []byte, msg *logMessage) error {
173-
var l = &jsonlog.JSONLog{}
174-
l.Reset()
184+
var l = &jsonLog{}
175185

176186
// TODO: JSON decoding is fairly expensive, we should evaluate this.
177187
if err := json.Unmarshal(log, l); err != nil {

vendor/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ filegroup(
112112
"//vendor/github.com/docker/distribution/registry/api/errcode:all-srcs",
113113
"//vendor/github.com/docker/docker/api:all-srcs",
114114
"//vendor/github.com/docker/docker/client:all-srcs",
115-
"//vendor/github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog:all-srcs",
116115
"//vendor/github.com/docker/docker/errdefs:all-srcs",
117116
"//vendor/github.com/docker/docker/pkg/jsonmessage:all-srcs",
118117
"//vendor/github.com/docker/docker/pkg/mount:all-srcs",

vendor/github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog/BUILD

Lines changed: 0 additions & 28 deletions
This file was deleted.

vendor/github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog/jsonlog.go

Lines changed: 0 additions & 25 deletions
This file was deleted.

vendor/github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog/jsonlogbytes.go

Lines changed: 0 additions & 125 deletions
This file was deleted.

vendor/github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog/time_marshalling.go

Lines changed: 0 additions & 20 deletions
This file was deleted.

vendor/modules.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@ github.com/docker/docker/api/types/time
233233
github.com/docker/docker/api/types/versions
234234
github.com/docker/docker/api/types/volume
235235
github.com/docker/docker/client
236-
github.com/docker/docker/daemon/logger/jsonfilelog/jsonlog
237236
github.com/docker/docker/errdefs
238237
github.com/docker/docker/pkg/jsonmessage
239238
github.com/docker/docker/pkg/mount

0 commit comments

Comments
 (0)