Skip to content

Commit e87cd59

Browse files
authored
Merge pull request kubernetes#88685 from fengzixu/move-util-functions
Refactor: move generic functions of integration test to util directory
2 parents 7e2394c + b67a033 commit e87cd59

File tree

12 files changed

+754
-707
lines changed

12 files changed

+754
-707
lines changed

test/integration/scheduler/BUILD

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ go_test(
6161
"//staging/src/k8s.io/kube-scheduler/extender/v1:go_default_library",
6262
"//test/e2e/framework/pod:go_default_library",
6363
"//test/integration/framework:go_default_library",
64+
"//test/integration/util:go_default_library",
6465
"//test/utils:go_default_library",
6566
"//test/utils/image:go_default_library",
6667
"//vendor/github.com/google/go-cmp/cmp:go_default_library",
@@ -89,34 +90,22 @@ go_library(
8990
"//pkg/api/v1/pod:go_default_library",
9091
"//pkg/controller/disruption:go_default_library",
9192
"//pkg/scheduler:go_default_library",
92-
"//pkg/scheduler/apis/config:go_default_library",
93-
"//pkg/scheduler/apis/config/scheme:go_default_library",
94-
"//pkg/scheduler/apis/config/v1:go_default_library",
95-
"//pkg/scheduler/profile:go_default_library",
96-
"//pkg/util/taints:go_default_library",
9793
"//staging/src/k8s.io/api/core/v1:go_default_library",
9894
"//staging/src/k8s.io/api/policy/v1beta1:go_default_library",
9995
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
10096
"//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
10197
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
10298
"//staging/src/k8s.io/apimachinery/pkg/labels:go_default_library",
103-
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
104-
"//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
105-
"//staging/src/k8s.io/apimachinery/pkg/util/uuid:go_default_library",
10699
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
107-
"//staging/src/k8s.io/apiserver/pkg/admission:go_default_library",
108100
"//staging/src/k8s.io/client-go/discovery/cached/memory:go_default_library",
109101
"//staging/src/k8s.io/client-go/dynamic:go_default_library",
110102
"//staging/src/k8s.io/client-go/informers:go_default_library",
111-
"//staging/src/k8s.io/client-go/informers/core/v1:go_default_library",
112103
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
113104
"//staging/src/k8s.io/client-go/listers/core/v1:go_default_library",
114105
"//staging/src/k8s.io/client-go/rest:go_default_library",
115106
"//staging/src/k8s.io/client-go/restmapper:go_default_library",
116107
"//staging/src/k8s.io/client-go/scale:go_default_library",
117-
"//staging/src/k8s.io/client-go/tools/cache:go_default_library",
118-
"//staging/src/k8s.io/client-go/tools/events:go_default_library",
119-
"//test/integration/framework:go_default_library",
108+
"//test/integration/util:go_default_library",
120109
"//test/utils/image:go_default_library",
121110
],
122111
)

test/integration/scheduler/extender_test.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import (
3535
clientset "k8s.io/client-go/kubernetes"
3636
extenderv1 "k8s.io/kube-scheduler/extender/v1"
3737
schedulerapi "k8s.io/kubernetes/pkg/scheduler/apis/config"
38+
testutils "k8s.io/kubernetes/test/integration/util"
3839
imageutils "k8s.io/kubernetes/test/utils/image"
3940
)
4041

@@ -279,8 +280,8 @@ func machine3Prioritizer(pod *v1.Pod, nodes *v1.NodeList) (*extenderv1.HostPrior
279280
}
280281

281282
func TestSchedulerExtender(t *testing.T) {
282-
testCtx := initTestMaster(t, "scheduler-extender", nil)
283-
clientSet := testCtx.clientSet
283+
testCtx := testutils.InitTestMaster(t, "scheduler-extender", nil)
284+
clientSet := testCtx.ClientSet
284285

285286
extender1 := &Extender{
286287
name: "extender1",
@@ -349,10 +350,10 @@ func TestSchedulerExtender(t *testing.T) {
349350
}
350351
policy.APIVersion = "v1"
351352

352-
testCtx = initTestScheduler(t, testCtx, false, &policy)
353-
defer cleanupTest(t, testCtx)
353+
testCtx = testutils.InitTestScheduler(t, testCtx, false, &policy)
354+
defer testutils.CleanupTest(t, testCtx)
354355

355-
DoTestPodScheduling(testCtx.ns, t, clientSet)
356+
DoTestPodScheduling(testCtx.NS, t, clientSet)
356357
}
357358

358359
func DoTestPodScheduling(ns *v1.Namespace, t *testing.T, cs clientset.Interface) {
@@ -405,7 +406,7 @@ func DoTestPodScheduling(ns *v1.Namespace, t *testing.T, cs clientset.Interface)
405406
t.Fatalf("Failed to create pod: %v", err)
406407
}
407408

408-
err = wait.Poll(time.Second, wait.ForeverTestTimeout, podScheduled(cs, myPod.Namespace, myPod.Name))
409+
err = wait.Poll(time.Second, wait.ForeverTestTimeout, testutils.PodScheduled(cs, myPod.Namespace, myPod.Name))
409410
if err != nil {
410411
t.Fatalf("Failed to schedule pod: %v", err)
411412
}

0 commit comments

Comments
 (0)