Skip to content

Commit e98f4f3

Browse files
committed
Use e2eskipper package in test/e2e/framework/
1 parent 5d1c301 commit e98f4f3

File tree

6 files changed

+9
-3
lines changed

6 files changed

+9
-3
lines changed

test/e2e/framework/network/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ go_library(
1919
"//test/e2e/framework:go_default_library",
2020
"//test/e2e/framework/node:go_default_library",
2121
"//test/e2e/framework/pod:go_default_library",
22+
"//test/e2e/framework/skipper:go_default_library",
2223
"//test/utils/image:go_default_library",
2324
"//vendor/github.com/onsi/ginkgo:go_default_library",
2425
],

test/e2e/framework/network/utils.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import (
4040
"k8s.io/kubernetes/test/e2e/framework"
4141
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
4242
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
43+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
4344
imageutils "k8s.io/kubernetes/test/utils/image"
4445
)
4546

@@ -619,7 +620,7 @@ func (config *NetworkingTestConfig) setup(selector map[string]string) {
619620
framework.ExpectNoError(err)
620621
config.ExternalAddr = e2enode.FirstAddress(nodeList, v1.NodeExternalIP)
621622

622-
framework.SkipUnlessNodeCountIsAtLeast(2)
623+
e2eskipper.SkipUnlessNodeCountIsAtLeast(2)
623624
config.Nodes = nodeList.Items
624625

625626
ginkgo.By("Creating the service on top of the pods in kubernetes")

test/e2e/framework/providers/gce/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ go_library(
2727
"//test/e2e/framework/pod:go_default_library",
2828
"//test/e2e/framework/pv:go_default_library",
2929
"//test/e2e/framework/service:go_default_library",
30+
"//test/e2e/framework/skipper:go_default_library",
3031
"//test/utils:go_default_library",
3132
"//vendor/github.com/onsi/ginkgo:go_default_library",
3233
"//vendor/google.golang.org/api/compute/v1:go_default_library",

test/e2e/framework/providers/gce/recreate_node.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
"k8s.io/kubernetes/test/e2e/framework"
3030
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
3131
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
32+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
3233
testutils "k8s.io/kubernetes/test/utils"
3334
)
3435

@@ -47,7 +48,7 @@ var _ = ginkgo.Describe("Recreate [Feature:Recreate]", func() {
4748
var ps *testutils.PodStore
4849
systemNamespace := metav1.NamespaceSystem
4950
ginkgo.BeforeEach(func() {
50-
framework.SkipUnlessProviderIs("gce", "gke")
51+
e2eskipper.SkipUnlessProviderIs("gce", "gke")
5152
var err error
5253
numNodes, err := e2enode.TotalRegistered(f.ClientSet)
5354
framework.ExpectNoError(err)

test/e2e/framework/pv/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ go_library(
1616
"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
1717
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
1818
"//test/e2e/framework:go_default_library",
19+
"//test/e2e/framework/skipper:go_default_library",
1920
"//vendor/github.com/onsi/ginkgo:go_default_library",
2021
],
2122
)

test/e2e/framework/pv/pv.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import (
3131
storageutil "k8s.io/kubernetes/pkg/apis/storage/v1/util"
3232
"k8s.io/kubernetes/pkg/volume/util"
3333
"k8s.io/kubernetes/test/e2e/framework"
34+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
3435
)
3536

3637
const (
@@ -795,6 +796,6 @@ func GetDefaultStorageClassName(c clientset.Interface) (string, error) {
795796
func SkipIfNoDefaultStorageClass(c clientset.Interface) {
796797
_, err := GetDefaultStorageClassName(c)
797798
if err != nil {
798-
framework.Skipf("error finding default storageClass : %v", err)
799+
e2eskipper.Skipf("error finding default storageClass : %v", err)
799800
}
800801
}

0 commit comments

Comments
 (0)