Skip to content

Commit ecd43f1

Browse files
Avoid using %#v for errors when %T or %s would be more accurate
`%#v` may have significant performance costs in frequently invoked code.
1 parent 082aee3 commit ecd43f1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

staging/src/k8s.io/client-go/rest/request.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ func (r *Request) WatchWithSpecificDecoders(wrapperDecoderFn func(io.ReadCloser)
592592
if result := r.transformResponse(resp, req); result.err != nil {
593593
return nil, result.err
594594
}
595-
return nil, fmt.Errorf("for request '%+v', got status: %v", url, resp.StatusCode)
595+
return nil, fmt.Errorf("for request %s, got status: %v", url, resp.StatusCode)
596596
}
597597
wrapperDecoder := wrapperDecoderFn(resp.Body)
598598
return watch.NewStreamWatcher(restclientwatch.NewDecoder(wrapperDecoder, embeddedDecoder)), nil
@@ -845,13 +845,13 @@ func (r *Request) transformResponse(resp *http.Response, req *http.Request) Resu
845845
// 3. Apiserver closes connection.
846846
// 4. client-go should catch this and return an error.
847847
klog.V(2).Infof("Stream error %#v when reading response body, may be caused by closed connection.", err)
848-
streamErr := fmt.Errorf("Stream error %#v when reading response body, may be caused by closed connection. Please retry.", err)
848+
streamErr := fmt.Errorf("Stream error when reading response body, may be caused by closed connection. Please retry. Original error: %v", err)
849849
return Result{
850850
err: streamErr,
851851
}
852852
default:
853-
klog.Errorf("Unexpected error when reading response body: %#v", err)
854-
unexpectedErr := fmt.Errorf("Unexpected error %#v when reading response body. Please retry.", err)
853+
klog.Errorf("Unexpected error when reading response body: %v", err)
854+
unexpectedErr := fmt.Errorf("Unexpected error when reading response body. Please retry. Original error: %v", err)
855855
return Result{
856856
err: unexpectedErr,
857857
}

0 commit comments

Comments
 (0)