Fix a lot of typos in Azure codes

Author: nilo19

staging/src/k8s.io/legacy-cloud-providers/azure/auth/azure_auth.go

@@ -213,7 +213,7 @@ func GetNetworkResourceServicePrincipalToken(config *AzureAuthConfig, env *azure
 }
 
 // ParseAzureEnvironment returns the azure environment.
-// If 'resourceManagerEndpoint' is set, the environment is computed by quering the cloud's resource manager endpoint.
+// If 'resourceManagerEndpoint' is set, the environment is computed by querying the cloud's resource manager endpoint.
 // Otherwise, a pre-defined Environment is looked up by name.
 func ParseAzureEnvironment(cloudName, resourceManagerEndpoint, identitySystem string) (*azure.Environment, error) {
 	var env azure.Environment

staging/src/k8s.io/legacy-cloud-providers/azure/auth/azure_auth_test.go

@@ -192,7 +192,7 @@ func TestGetNetworkResourceServicePrincipalTokenNegative(t *testing.T) {
 	}
 }
 
-func TestParseAzureEngironment(t *testing.T) {
+func TestParseAzureEnvironment(t *testing.T) {
 	cases := []struct {
 		cloudName               string
 		resourceManagerEndpoint string

staging/src/k8s.io/legacy-cloud-providers/azure/azure.go

@@ -96,8 +96,8 @@ const (
 const (
 	// PreConfiguredBackendPoolLoadBalancerTypesNone means that the load balancers are not pre-configured
 	PreConfiguredBackendPoolLoadBalancerTypesNone = ""
-	// PreConfiguredBackendPoolLoadBalancerTypesInteral means that the `internal` load balancers are pre-configured
-	PreConfiguredBackendPoolLoadBalancerTypesInteral = "internal"
+	// PreConfiguredBackendPoolLoadBalancerTypesInternal means that the `internal` load balancers are pre-configured
+	PreConfiguredBackendPoolLoadBalancerTypesInternal = "internal"
 	// PreConfiguredBackendPoolLoadBalancerTypesExternal means that the `external` load balancers are pre-configured
 	PreConfiguredBackendPoolLoadBalancerTypesExternal = "external"
 	// PreConfiguredBackendPoolLoadBalancerTypesAll means that all load balancers are pre-configured
@@ -383,7 +383,7 @@ func (az *Cloud) InitializeCloudFromConfig(config *Config, fromSecret bool) erro
 	if err == auth.ErrorNoAuth {
 		// Only controller-manager would lazy-initialize from secret, and credentials are required for such case.
 		if fromSecret {
-			err := fmt.Errorf("No credentials provided for Azure cloud provider")
+			err := fmt.Errorf("no credentials provided for Azure cloud provider")
 			klog.Fatalf("%v", err)
 			return err
 		}
@@ -810,7 +810,7 @@ func (az *Cloud) updateNodeCaches(prevNode, newNode *v1.Node) {
 // GetActiveZones returns all the zones in which k8s nodes are currently running.
 func (az *Cloud) GetActiveZones() (sets.String, error) {
 	if az.nodeInformerSynced == nil {
-		return nil, fmt.Errorf("Azure cloud provider doesn't have informers set")
+		return nil, fmt.Errorf("azure cloud provider doesn't have informers set")
 	}
 
 	az.nodeCachesLock.RLock()

staging/src/k8s.io/legacy-cloud-providers/azure/azure_backoff.go

@@ -68,9 +68,9 @@ func (az *Cloud) RequestBackoff() (resourceRequestBackoff wait.Backoff) {
 }
 
 // Event creates a event for the specified object.
-func (az *Cloud) Event(obj runtime.Object, eventtype, reason, message string) {
+func (az *Cloud) Event(obj runtime.Object, eventType, reason, message string) {
 	if obj != nil && reason != "" {
-		az.eventRecorder.Event(obj, eventtype, reason, message)
+		az.eventRecorder.Event(obj, eventType, reason, message)
 	}
 }
 
@@ -359,7 +359,7 @@ func (az *Cloud) CreateOrUpdateRouteTable(routeTable network.RouteTable) error {
 	}
 	// Invalidate the cache because another new operation has canceled the current request.
 	if strings.Contains(strings.ToLower(rerr.Error().Error()), operationCanceledErrorMessage) {
-		klog.V(3).Infof("Route table cache for %s is cleanup because CreateOrUpdateRouteTable is canceld by another operation", *routeTable.Name)
+		klog.V(3).Infof("Route table cache for %s is cleanup because CreateOrUpdateRouteTable is canceled by another operation", *routeTable.Name)
 		az.rtCache.Delete(*routeTable.Name)
 	}
 	klog.Errorf("RouteTablesClient.CreateOrUpdate(%s) failed: %v", az.RouteTableName, rerr.Error())
@@ -384,7 +384,7 @@ func (az *Cloud) CreateOrUpdateRoute(route network.Route) error {
 	}
 	// Invalidate the cache because another new operation has canceled the current request.
 	if strings.Contains(strings.ToLower(rerr.Error().Error()), operationCanceledErrorMessage) {
-		klog.V(3).Infof("Route cache for %s is cleanup because CreateOrUpdateRouteTable is canceld by another operation", *route.Name)
+		klog.V(3).Infof("Route cache for %s is cleanup because CreateOrUpdateRouteTable is canceled by another operation", *route.Name)
 		az.rtCache.Delete(az.RouteTableName)
 	}
 	return rerr.Error()

staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController.go

@@ -254,7 +254,7 @@ func (c *BlobDiskController) CreateBlobDisk(dataDiskName string, storageAccountT
 
 //DeleteBlobDisk : delete a blob disk from a node
 func (c *BlobDiskController) DeleteBlobDisk(diskURI string) error {
-	storageAccountName, vhdName, err := diskNameandSANameFromURI(diskURI)
+	storageAccountName, vhdName, err := diskNameAndSANameFromURI(diskURI)
 	if err != nil {
 		return err
 	}
@@ -468,13 +468,13 @@ func (c *BlobDiskController) getAllStorageAccounts() (map[string]*storageAccount
 		}
 		klog.Infof("azureDisk - identified account %s as part of shared PVC accounts", *v.Name)
 
-		sastate := &storageAccountState{
+		saState := &storageAccountState{
 			name:      *v.Name,
 			saType:    (*v.Sku).Name,
 			diskCount: -1,
 		}
 
-		accounts[*v.Name] = sastate
+		accounts[*v.Name] = saState
 	}
 
 	return accounts, nil
@@ -578,7 +578,7 @@ func (c *BlobDiskController) findSANameForDisk(storageAccountType storage.SkuNam
 	disksAfter := totalDiskCounts + 1 // with the new one!
 
 	avgUtilization := float64(disksAfter) / float64(countAccounts*maxDisksPerStorageAccounts)
-	aboveAvg := (avgUtilization > storageAccountUtilizationBeforeGrowing)
+	aboveAvg := avgUtilization > storageAccountUtilizationBeforeGrowing
 
 	// avg are not create and we should create more accounts if we can
 	if aboveAvg && countAccounts < maxStorageAccounts {
@@ -631,7 +631,7 @@ func createVHDHeader(size uint64) ([]byte, error) {
 	return b.Bytes(), nil
 }
 
-func diskNameandSANameFromURI(diskURI string) (string, string, error) {
+func diskNameAndSANameFromURI(diskURI string) (string, string, error) {
 	uri, err := url.Parse(diskURI)
 	if err != nil {
 		return "", "", err

staging/src/k8s.io/legacy-cloud-providers/azure/azure_controller_common_test.go

@@ -294,7 +294,7 @@ func TestCommonDetachDisk(t *testing.T) {
 			expectedErr: false,
 		},
 		{
-			desc:        "no error shall be returned if the disk exsists",
+			desc:        "no error shall be returned if the disk exists",
 			vmList:      map[string]string{"vm1": "PowerState/Running"},
 			nodeName:    "vm1",
 			diskName:    "disk1",

staging/src/k8s.io/legacy-cloud-providers/azure/azure_instance_metadata.go

@@ -153,7 +153,7 @@ func (ims *InstanceMetadataService) GetMetadata(crt azcache.AzureCacheReadType)
 		return nil, err
 	}
 
-	// Cache shouldn't be nil, but added a check incase something wrong.
+	// Cache shouldn't be nil, but added a check in case something is wrong.
 	if cache == nil {
 		return nil, fmt.Errorf("failure of getting instance metadata")
 	}

staging/src/k8s.io/legacy-cloud-providers/azure/azure_instances.go

@@ -258,7 +258,7 @@ func (az *Cloud) isCurrentInstance(name types.NodeName, metadataVMName string) (
 	}
 
 	metadataVMName = strings.ToLower(metadataVMName)
-	return (metadataVMName == nodeName), nil
+	return metadataVMName == nodeName, nil
 }
 
 // InstanceID returns the cloud provider ID of the specified instance.

staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go

@@ -1609,7 +1609,7 @@ func (az *Cloud) reconcileSecurityGroup(clusterName string, service *v1.Service,
 	if ports == nil {
 		if useSharedSecurityRule(service) {
 			klog.V(2).Infof("Attempting to reconcile security group for service %s, but service uses shared rule and we don't know which port it's for", service.Name)
-			return nil, fmt.Errorf("No port info for reconciling shared rule for service %s", service.Name)
+			return nil, fmt.Errorf("no port info for reconciling shared rule for service %s", service.Name)
 		}
 		ports = []v1.ServicePort{}
 	}
@@ -1621,7 +1621,7 @@ func (az *Cloud) reconcileSecurityGroup(clusterName string, service *v1.Service,
 
 	destinationIPAddress := ""
 	if wantLb && lbIP == nil {
-		return nil, fmt.Errorf("No load balancer IP for setting up security rules for service %s", service.Name)
+		return nil, fmt.Errorf("no load balancer IP for setting up security rules for service %s", service.Name)
 	}
 	if lbIP != nil {
 		destinationIPAddress = *lbIP
@@ -1724,17 +1724,17 @@ func (az *Cloud) reconcileSecurityGroup(clusterName string, service *v1.Service,
 				sharedIndex, sharedRule, sharedRuleFound := findSecurityRuleByName(updatedRules, sharedRuleName)
 				if !sharedRuleFound {
 					klog.V(4).Infof("Expected to find shared rule %s for service %s being deleted, but did not", sharedRuleName, service.Name)
-					return nil, fmt.Errorf("Expected to find shared rule %s for service %s being deleted, but did not", sharedRuleName, service.Name)
+					return nil, fmt.Errorf("expected to find shared rule %s for service %s being deleted, but did not", sharedRuleName, service.Name)
 				}
 				if sharedRule.DestinationAddressPrefixes == nil {
 					klog.V(4).Infof("Expected to have array of destinations in shared rule for service %s being deleted, but did not", service.Name)
-					return nil, fmt.Errorf("Expected to have array of destinations in shared rule for service %s being deleted, but did not", service.Name)
+					return nil, fmt.Errorf("expected to have array of destinations in shared rule for service %s being deleted, but did not", service.Name)
 				}
 				existingPrefixes := *sharedRule.DestinationAddressPrefixes
 				addressIndex, found := findIndex(existingPrefixes, destinationIPAddress)
 				if !found {
 					klog.V(4).Infof("Expected to find destination address %s in shared rule %s for service %s being deleted, but did not", destinationIPAddress, sharedRuleName, service.Name)
-					return nil, fmt.Errorf("Expected to find destination address %s in shared rule %s for service %s being deleted, but did not", destinationIPAddress, sharedRuleName, service.Name)
+					return nil, fmt.Errorf("expected to find destination address %s in shared rule %s for service %s being deleted, but did not", destinationIPAddress, sharedRuleName, service.Name)
 				}
 				if len(existingPrefixes) == 1 {
 					updatedRules = append(updatedRules[:sharedIndex], updatedRules[sharedIndex+1:]...)
@@ -2282,7 +2282,7 @@ func (az *Cloud) isBackendPoolPreConfigured(service *v1.Service) bool {
 	if az.PreConfiguredBackendPoolLoadBalancerTypes == PreConfiguredBackendPoolLoadBalancerTypesAll {
 		preConfigured = true
 	}
-	if (az.PreConfiguredBackendPoolLoadBalancerTypes == PreConfiguredBackendPoolLoadBalancerTypesInteral) && isInternal {
+	if (az.PreConfiguredBackendPoolLoadBalancerTypes == PreConfiguredBackendPoolLoadBalancerTypesInternal) && isInternal {
 		preConfigured = true
 	}
 	if (az.PreConfiguredBackendPoolLoadBalancerTypes == PreConfiguredBackendPoolLoadBalancerTypesExternal) && !isInternal {

staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer_test.go

@@ -56,7 +56,7 @@ func TestFindProbe(t *testing.T) {
 			expected: false,
 		},
 		{
-			msg: "probe names match while ports unmatch should return false",
+			msg: "probe names match while ports don't should return false",
 			existingProbe: []network.Probe{
 				{
 					Name: to.StringPtr("httpProbe"),
@@ -74,7 +74,7 @@ func TestFindProbe(t *testing.T) {
 			expected: false,
 		},
 		{
-			msg: "probe ports match while names unmatch should return false",
+			msg: "probe ports match while names don't should return false",
 			existingProbe: []network.Probe{
 				{
 					Name: to.StringPtr("probe1"),
@@ -129,7 +129,7 @@ func TestFindRule(t *testing.T) {
 			expected: false,
 		},
 		{
-			msg: "rule names unmatch should return false",
+			msg: "rule names don't match should return false",
 			existingRule: []network.LoadBalancingRule{
 				{
 					Name: to.StringPtr("httpProbe1"),
@@ -147,7 +147,7 @@ func TestFindRule(t *testing.T) {
 			expected: false,
 		},
 		{
-			msg: "rule names match while frontend ports unmatch should return false",
+			msg: "rule names match while frontend ports don't should return false",
 			existingRule: []network.LoadBalancingRule{
 				{
 					Name: to.StringPtr("httpProbe"),
@@ -165,7 +165,7 @@ func TestFindRule(t *testing.T) {
 			expected: false,
 		},
 		{
-			msg: "rule names match while backend ports unmatch should return false",
+			msg: "rule names match while backend ports don't should return false",
 			existingRule: []network.LoadBalancingRule{
 				{
 					Name: to.StringPtr("httpProbe"),
@@ -183,7 +183,7 @@ func TestFindRule(t *testing.T) {
 			expected: false,
 		},
 		{
-			msg: "rule names match while idletimeout unmatch should return false",
+			msg: "rule names match while idletimeout don't should return false",
 			existingRule: []network.LoadBalancingRule{
 				{
 					Name: to.StringPtr("httpRule"),
@@ -217,7 +217,7 @@ func TestFindRule(t *testing.T) {
 			expected: true,
 		},
 		{
-			msg: "rule names match while LoadDistribution unmatch should return false",
+			msg: "rule names match while LoadDistribution don't should return false",
 			existingRule: []network.LoadBalancingRule{
 				{
 					Name: to.StringPtr("probe1"),
@@ -722,7 +722,7 @@ func TestShouldReleaseExistingOwnedPublicIP(t *testing.T) {
 	}
 }
 
-func TestgetIPTagMap(t *testing.T) {
+func TestGetIPTagMap(t *testing.T) {
 	tests := []struct {
 		desc     string
 		input    string
@@ -1170,7 +1170,7 @@ func TestGetServiceLoadBalancer(t *testing.T) {
 			expectedError:  false,
 		},
 		{
-			desc:           "getServiceLoadBalancer shall report error if there're loadbalancer mode annotations on a standard lb",
+			desc:           "getServiceLoadBalancer shall report error if there are loadbalancer mode annotations on a standard lb",
 			service:        getTestService("service1", v1.ProtocolTCP, nil, false, 80),
 			annotations:    map[string]string{ServiceAnnotationLoadBalancerMode: "__auto__"},
 			sku:            "standard",