Skip to content

Commit ece8aef

Browse files
committed
fix: azure error should not retry on bad reqeust
1 parent 0387ee4 commit ece8aef

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

staging/src/k8s.io/legacy-cloud-providers/azure/retry/azure_error.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,9 @@ func getHTTPStatusCode(resp *http.Response) int {
125125
// shouldRetryHTTPRequest determines if the request is retriable.
126126
func shouldRetryHTTPRequest(resp *http.Response, err error) bool {
127127
if resp != nil {
128-
// HTTP 412 (StatusPreconditionFailed) means etag mismatch, hence we shouldn't retry.
129-
if resp.StatusCode == http.StatusPreconditionFailed {
128+
// HTTP 412 (StatusPreconditionFailed) means etag mismatch
129+
// HTTP 400 (BadRequest) means the request cannot be accepted, hence we shouldn't retry.
130+
if resp.StatusCode == http.StatusPreconditionFailed || resp.StatusCode == http.StatusBadRequest {
130131
return false
131132
}
132133

0 commit comments

Comments
 (0)