replace errors.New(fmt.Sprintf()) with fmt.Errorf()

danielqsj · danielqsj · commit ed9a3fae8e2c · 2019-05-05T17:48:20.000+08:00
diff --git a/staging/src/k8s.io/legacy-cloud-providers/vsphere/vsphere.go b/staging/src/k8s.io/legacy-cloud-providers/vsphere/vsphere.go
@@ -609,7 +609,7 @@ func (vs *VSphere) getVSphereInstanceForServer(vcServer string, ctx context.Cont
 	vsphereIns, ok := vs.vsphereInstanceMap[vcServer]
 	if !ok {
 		klog.Errorf("cannot find vcServer %q in cache. VC not found!!!", vcServer)
-		return nil, errors.New(fmt.Sprintf("Cannot find node %q in vsphere configuration map", vcServer))
+		return nil, fmt.Errorf("cannot find node %q in vsphere configuration map", vcServer)
 	}
 	// Ensure client is logged in and session is valid
 	err := vs.nodeManager.vcConnect(ctx, vsphereIns)

Original file line number	Diff line number	Diff line change
`@@ -609,7 +609,7 @@ func (vs *VSphere) getVSphereInstanceForServer(vcServer string, ctx context.Cont`
`609`	`609`	`vsphereIns, ok := vs.vsphereInstanceMap[vcServer]`
`610`	`610`	`if !ok {`
`611`	`611`	`klog.Errorf("cannot find vcServer %q in cache. VC not found!!!", vcServer)`
`612`		`- return nil, errors.New(fmt.Sprintf("Cannot find node %q in vsphere configuration map", vcServer))`
	`612`	`+ return nil, fmt.Errorf("cannot find node %q in vsphere configuration map", vcServer)`
`613`	`613`	`}`
`614`	`614`	`// Ensure client is logged in and session is valid`
`615`	`615`	`err := vs.nodeManager.vcConnect(ctx, vsphereIns)`