Skip to content

Commit eda662b

Browse files
authored
Merge pull request kubernetes#91691 from liggitt/kubectl-csr-v1beta1
Make kubectl tolerate other versions of the CSR API
2 parents 4d59db4 + ea6e5e5 commit eda662b

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

staging/src/k8s.io/kubectl/pkg/cmd/certificates/certificates.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ func (o *CertificateOptions) modifyCertificateCondition(builder *resource.Builde
222222
WithScheme(scheme.Scheme, scheme.Scheme.PrioritizedVersionsAllGroups()...).
223223
ContinueOnError().
224224
FilenameParam(false, &o.FilenameOptions).
225-
ResourceNames("certificatesigningrequest", o.csrNames...).
225+
ResourceNames("certificatesigningrequests.v1beta1.certificates.k8s.io", o.csrNames...).
226226
RequireObject(true).
227227
Flatten().
228228
Latest().
@@ -232,7 +232,10 @@ func (o *CertificateOptions) modifyCertificateCondition(builder *resource.Builde
232232
return err
233233
}
234234
for i := 0; ; i++ {
235-
csr := info.Object.(*certificatesv1beta1.CertificateSigningRequest)
235+
csr, ok := info.Object.(*certificatesv1beta1.CertificateSigningRequest)
236+
if !ok {
237+
return fmt.Errorf("can only handle certificates.k8s.io/v1beta1 certificate signing requests")
238+
}
236239
csr, hasCondition := modify(csr)
237240
if !hasCondition || force {
238241
_, err = clientSet.CertificateSigningRequests().UpdateApproval(context.TODO(), csr, metav1.UpdateOptions{})

0 commit comments

Comments
 (0)