Skip to content

Commit ee297b6

Browse files
authored
Merge pull request kubernetes#95053 from tanjunchen/replace-k8s-master
test/e2e/framework/:use the term 'Control Plane' in comment
2 parents 7786616 + 818238a commit ee297b6

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

test/e2e/framework/ingress/ingress_utils.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -883,8 +883,8 @@ func getPortURL(client clientset.Interface, ns, name string, svcPort int) (strin
883883
if err != nil {
884884
return "", err
885885
}
886-
// This list of nodes must not include the master, which is marked
887-
// unschedulable, since the master doesn't run kube-proxy. Without
886+
// This list of nodes must not include the any control plane nodes, which are marked
887+
// unschedulable, since control plane nodes don't run kube-proxy. Without
888888
// kube-proxy NodePorts won't work.
889889
var nodes *v1.NodeList
890890
if wait.PollImmediate(poll, framework.SingleCallTimeout, func() (bool, error) {

test/e2e/framework/node/resource.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ func Filter(nodeList *v1.NodeList, fn func(node v1.Node) bool) {
191191
nodeList.Items = l
192192
}
193193

194-
// TotalRegistered returns number of registered Nodes excluding Master Node.
194+
// TotalRegistered returns number of schedulable Nodes.
195195
func TotalRegistered(c clientset.Interface) (int, error) {
196196
nodes, err := waitListSchedulableNodes(c)
197197
if err != nil {
@@ -201,7 +201,7 @@ func TotalRegistered(c clientset.Interface) (int, error) {
201201
return len(nodes.Items), nil
202202
}
203203

204-
// TotalReady returns number of ready Nodes excluding Master Node.
204+
// TotalReady returns number of ready schedulable Nodes.
205205
func TotalReady(c clientset.Interface) (int, error) {
206206
nodes, err := waitListSchedulableNodes(c)
207207
if err != nil {

test/e2e/framework/node/wait.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ var requiredPerNodePods = []*regexp.Regexp{
4040
}
4141

4242
// WaitForReadyNodes waits up to timeout for cluster to has desired size and
43-
// there is no not-ready nodes in it. By cluster size we mean number of Nodes
44-
// excluding Master Node.
43+
// there is no not-ready nodes in it. By cluster size we mean number of schedulable Nodes.
4544
func WaitForReadyNodes(c clientset.Interface, size int, timeout time.Duration) error {
4645
_, err := CheckReady(c, size, timeout)
4746
return err
@@ -149,8 +148,7 @@ func WaitForNodeToBeReady(c clientset.Interface, name string, timeout time.Durat
149148
}
150149

151150
// CheckReady waits up to timeout for cluster to has desired size and
152-
// there is no not-ready nodes in it. By cluster size we mean number of Nodes
153-
// excluding Master Node.
151+
// there is no not-ready nodes in it. By cluster size we mean number of schedulable Nodes.
154152
func CheckReady(c clientset.Interface, size int, timeout time.Duration) ([]v1.Node, error) {
155153
for start := time.Now(); time.Since(start) < timeout; time.Sleep(sleepTime) {
156154
nodes, err := waitListSchedulableNodes(c)

test/e2e/framework/ssh/ssh.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ func makePrivateKeySignerFromFile(key string) (ssh.Signer, error) {
112112
return signer, err
113113
}
114114

115-
// NodeSSHHosts returns SSH-able host names for all schedulable nodes - this
116-
// excludes master node. If it can't find any external IPs, it falls back to
115+
// NodeSSHHosts returns SSH-able host names for all schedulable nodes.
116+
// If it can't find any external IPs, it falls back to
117117
// looking for internal IPs. If it can't find an internal IP for every node it
118118
// returns an error, though it still returns all hosts that it found in that
119119
// case.

0 commit comments

Comments
 (0)