Skip to content

Commit ee81b30

Browse files
authored
Merge pull request kubernetes#85323 from tanjunchen/use-ExpectEqual-test/e2e/auth
use ExpectEqual in /e2e/auth
2 parents 93c2eed + e975774 commit ee81b30

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

test/e2e/auth/node_authn.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ package auth
1919
import (
2020
"fmt"
2121

22-
"k8s.io/api/core/v1"
22+
v1 "k8s.io/api/core/v1"
2323
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2424
"k8s.io/kubernetes/pkg/master/ports"
2525
"k8s.io/kubernetes/test/e2e/framework"
@@ -40,7 +40,7 @@ var _ = SIGDescribe("[Feature:NodeAuthenticator]", func() {
4040

4141
nodeList, err := f.ClientSet.CoreV1().Nodes().List(metav1.ListOptions{})
4242
framework.ExpectNoError(err, "failed to list nodes in namespace: %s", ns)
43-
gomega.Expect(len(nodeList.Items)).NotTo(gomega.BeZero())
43+
framework.ExpectNotEqual(len(nodeList.Items), 0)
4444

4545
pickedNode := nodeList.Items[0]
4646
nodeIPs = e2enode.GetAddresses(&pickedNode, v1.NodeExternalIP)
@@ -51,7 +51,8 @@ var _ = SIGDescribe("[Feature:NodeAuthenticator]", func() {
5151
saName := "default"
5252
sa, err := f.ClientSet.CoreV1().ServiceAccounts(ns).Get(saName, metav1.GetOptions{})
5353
framework.ExpectNoError(err, "failed to retrieve service account (%s:%s)", ns, saName)
54-
gomega.Expect(len(sa.Secrets)).NotTo(gomega.BeZero())
54+
framework.ExpectNotEqual(len(sa.Secrets), 0)
55+
5556
})
5657

5758
ginkgo.It("The kubelet's main port 10250 should reject requests with no credentials", func() {

test/e2e/auth/pod_security_policy.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import (
3838
utilpointer "k8s.io/utils/pointer"
3939

4040
"github.com/onsi/ginkgo"
41-
"github.com/onsi/gomega"
4241
)
4342

4443
const nobodyUser = int64(65534)
@@ -115,15 +114,15 @@ var _ = SIGDescribe("PodSecurityPolicy", func() {
115114
p, err = c.CoreV1().Pods(ns).Get(p.Name, metav1.GetOptions{})
116115
framework.ExpectNoError(err)
117116
validated, found := p.Annotations[psputil.ValidatedPSPAnnotation]
118-
gomega.Expect(found).To(gomega.BeTrue(), "PSP annotation not found")
117+
framework.ExpectEqual(found, true, "PSP annotation not found")
119118
framework.ExpectEqual(validated, expectedPSP.Name, "Unexpected validated PSP")
120119
})
121120
})
122121
})
123122

124123
func expectForbidden(err error) {
125124
framework.ExpectError(err, "should be forbidden")
126-
gomega.Expect(apierrs.IsForbidden(err)).To(gomega.BeTrue(), "should be forbidden error")
125+
framework.ExpectEqual(apierrs.IsForbidden(err), true, "should be forbidden error")
127126
}
128127

129128
func testPrivilegedPods(tester func(pod *v1.Pod)) {

0 commit comments

Comments
 (0)