Skip to content

Commit ef446db

Browse files
authored
Merge pull request kubernetes#89104 from aojea/e2emetrics
fix logging on e2e metrics grabber test
2 parents ff21f45 + 334d46e commit ef446db

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/e2e/framework/metrics/metrics_grabber.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ func (g *Grabber) GrabFromControllerManager() (ControllerManagerMetrics, error)
170170
podName := fmt.Sprintf("%v-%v", "kube-controller-manager", g.masterName)
171171
g.waitForControllerManagerReadyOnce.Do(func() {
172172
if runningErr := e2epod.WaitForPodNameRunningInNamespace(g.client, podName, metav1.NamespaceSystem); runningErr != nil {
173-
err = fmt.Errorf("error waiting for controller manager pod to be running: %w", err)
173+
err = fmt.Errorf("error waiting for controller manager pod to be running: %w", runningErr)
174174
return
175175
}
176176

@@ -179,7 +179,7 @@ func (g *Grabber) GrabFromControllerManager() (ControllerManagerMetrics, error)
179179
_, lastMetricsFetchErr = g.getMetricsFromPod(g.client, podName, metav1.NamespaceSystem, ports.InsecureKubeControllerManagerPort)
180180
return lastMetricsFetchErr == nil, nil
181181
}); metricsWaitErr != nil {
182-
err = fmt.Errorf("error waiting for controller manager pod to expose metrics: %v; %v", err, lastMetricsFetchErr)
182+
err = fmt.Errorf("error waiting for controller manager pod to expose metrics: %v; %v", metricsWaitErr, lastMetricsFetchErr)
183183
return
184184
}
185185
})

0 commit comments

Comments
 (0)