Skip to content

Commit f01d848

Browse files
authored
Merge pull request kubernetes#91329 from dims/switch-kube-controller-manager-to-distroless-image
Switch kube-controller-manager to distroless image
2 parents 9f5d9a9 + b1742f1 commit f01d848

File tree

7 files changed

+9
-8
lines changed

7 files changed

+9
-8
lines changed

build/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ DOCKERIZED_BINARIES = {
3535
"target": "//cmd/kube-apiserver:kube-apiserver",
3636
},
3737
"kube-controller-manager": {
38-
"base": "@debian-base-{ARCH}//image",
38+
"base": "@go-runner-linux-{ARCH}//image",
3939
"target": "//cmd/kube-controller-manager:kube-controller-manager",
4040
},
4141
"kube-scheduler": {

build/common.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ kube::build::get_docker_wrapped_binaries() {
101101
### in build/BUILD. And kube::golang::server_image_targets
102102
local targets=(
103103
"kube-apiserver,${KUBE_BASE_IMAGE_REGISTRY}/go-runner:${go_runner_version}"
104-
"kube-controller-manager,${KUBE_BASE_IMAGE_REGISTRY}/debian-base-${arch}:${debian_base_version}"
104+
"kube-controller-manager,${KUBE_BASE_IMAGE_REGISTRY}/go-runner:${go_runner_version}"
105105
"kube-scheduler,${KUBE_BASE_IMAGE_REGISTRY}/go-runner:${go_runner_version}"
106106
"kube-proxy,${KUBE_BASE_IMAGE_REGISTRY}/debian-iptables-${arch}:${debian_iptables_version}"
107107
)

cluster/gce/gci/configure-helper.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1920,6 +1920,7 @@ function start-kube-controller-manager {
19201920
container_env="\"env\":[{\"name\": \"KUBE_CACHE_MUTATION_DETECTOR\", \"value\": \"${ENABLE_CACHE_MUTATION_DETECTOR}\"}],"
19211921
fi
19221922

1923+
params="$(convert-manifest-params "${params}")"
19231924
local -r src_file="${KUBE_HOME}/kube-manifests/kubernetes/gci-trusty/kube-controller-manager.manifest"
19241925
# Evaluate variables.
19251926
sed -i -e "s@{{pillar\['kube_docker_registry'\]}}@${DOCKER_REGISTRY}@g" "${src_file}"

cluster/gce/manifests/kube-controller-manager.manifest

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
}
2727
},
2828
"command": [
29-
"/bin/sh",
30-
"-c",
31-
"exec /usr/local/bin/kube-controller-manager {{params}} 1>>/var/log/kube-controller-manager.log 2>&1"
29+
"/go-runner", "--log-file=/var/log/kube-controller-manager.log", "--also-stdout=false", "--redirect-stderr=true",
30+
"/usr/local/bin/kube-controller-manager",
31+
{{params}}
3232
],
3333
{{container_env}}
3434
"livenessProbe": {

test/e2e/storage/detach_mounted.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ var (
4343
durationForStuckMount = 110 * time.Second
4444
)
4545

46-
var _ = utils.SIGDescribe("Detaching volumes", func() {
46+
var _ = utils.SIGDescribe("[Feature:Flexvolumes] Detaching volumes", func() {
4747
f := framework.NewDefaultFramework("flexvolume")
4848

4949
// note that namespace deletion is handled by delete-namespace flag

test/e2e/storage/flexvolume.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ var _ = utils.SIGDescribe("Flexvolumes", func() {
200200
uninstallFlex(cs, node, "k8s", driverInstallAs)
201201
})
202202

203-
ginkgo.It("should be mountable when attachable", func() {
203+
ginkgo.It("should be mountable when attachable [Feature:Flexvolumes]", func() {
204204
driver := "dummy-attachable"
205205
driverInstallAs := driver + "-" + suffix
206206

test/e2e/storage/flexvolume_mounted_volume_resize.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const (
4545
totalResizeWaitPeriod = 5 * time.Minute
4646
)
4747

48-
var _ = utils.SIGDescribe("Mounted flexvolume expand[Slow]", func() {
48+
var _ = utils.SIGDescribe("[Feature:Flexvolumes] Mounted flexvolume expand[Slow]", func() {
4949
var (
5050
c clientset.Interface
5151
ns string

0 commit comments

Comments
 (0)