Skip to content

Commit f12a40d

Browse files
authored
Merge pull request kubernetes#81547 from BenTheElder/typecheck-cleanup
typecheck cleanup
2 parents 3f00331 + 6b038f3 commit f12a40d

File tree

3 files changed

+2
-22
lines changed

3 files changed

+2
-22
lines changed

test/typecheck/OWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# See the OWNERS docs at https://go.k8s.io/owners
22

33
reviewers:
4+
- BenTheElder
45
- cblecker
5-
- rmmh
66
approvers:
77
- cblecker
88
- rmmh

test/typecheck/main.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -103,26 +103,6 @@ func newAnalyzer(platform string) *analyzer {
103103
}
104104

105105
func (a *analyzer) handleError(err error) {
106-
if e, ok := err.(types.Error); ok {
107-
// useful for some ignores:
108-
// path := e.Fset.Position(e.Pos).String()
109-
ignore := false
110-
// TODO(rmmh): read ignores from a file, so this code can
111-
// be Kubernetes-agnostic. Unused ignores should be treated as
112-
// errors, to ensure coverage isn't overly broad.
113-
if strings.Contains(e.Msg, "GetOpenAPIDefinitions") {
114-
// TODO(rmmh): figure out why this happens.
115-
// cmd/kube-apiserver/app/server.go:392:70
116-
// test/integration/framework/master_utils.go:131:84
117-
ignore = true
118-
}
119-
if ignore {
120-
if *verbose {
121-
fmt.Println("ignoring error:", err)
122-
}
123-
return
124-
}
125-
}
126106
a.errors = append(a.errors, err.Error())
127107
if *serial {
128108
fmt.Fprintf(os.Stderr, "%sERROR(%s) %s\n", logPrefix, a.platform, err)

third_party/go-srcimporter/OWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# See the OWNERS docs at https://go.k8s.io/owners
22

33
reviewers:
4+
- BenTheElder
45
- cblecker
5-
- rmmh
66
approvers:
77
- cblecker
88
- rmmh

0 commit comments

Comments
 (0)