Merge pull request kubernetes#67306 from dougm/vcp-test-ca

Kubernetes Submit Queue · web-flow · commit f35065bf443b · 2018-08-13T03:41:58.000-07:00
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. vsphere: enable TestInvalidCaCert This test can be enabled now with the govmomi vendor update in 5c44fd8 **What this PR does / why we need it**: Enables a test that had been skipped due to vendor dependency. ```release-note NONE ```
diff --git a/pkg/cloudprovider/providers/vsphere/vclib/connection_test.go b/pkg/cloudprovider/providers/vsphere/vclib/connection_test.go
@@ -170,8 +170,6 @@ func TestWithInvalidCaCertPath(t *testing.T) {
 }
 
 func TestInvalidCaCert(t *testing.T) {
-	t.Skip("Waiting for https://github.com/vmware/govmomi/pull/1154")
-
 	connection := &vclib.VSphereConnection{
 		Hostname: "should-not-matter",
 		Port:     "should-not-matter",

Original file line number	Diff line number	Diff line change
`@@ -170,8 +170,6 @@ func TestWithInvalidCaCertPath(t *testing.T) {`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`func TestInvalidCaCert(t *testing.T) {`
`173`		`- t.Skip("Waiting for https://github.com/vmware/govmomi/pull/1154")`
`174`		`-`
`175`	`173`	`connection := &vclib.VSphereConnection{`
`176`	`174`	`Hostname: "should-not-matter",`
`177`	`175`	`Port: "should-not-matter",`