Skip to content

Commit f5c6eba

Browse files
committed
Add LinuxOnly tag to e2e testing session affinity
1 parent c4f3917 commit f5c6eba

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

test/e2e/network/networking.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,8 @@ var _ = SIGDescribe("Networking", func() {
202202
config.DialFromNode("udp", config.NodeIP, config.NodeUDPPort, config.MaxTries, config.MaxTries, sets.NewString())
203203
})
204204

205-
ginkgo.It("should function for client IP based session affinity: http", func() {
205+
// [LinuxOnly]: Windows does not support session affinity.
206+
ginkgo.It("should function for client IP based session affinity: http [LinuxOnly]", func() {
206207
config := framework.NewNetworkingTestConfig(f)
207208
ginkgo.By(fmt.Sprintf("dialing(http) %v --> %v:%v", config.TestContainerPod.Name, config.SessionAffinityService.Spec.ClusterIP, framework.ClusterHTTPPort))
208209

@@ -219,7 +220,8 @@ var _ = SIGDescribe("Networking", func() {
219220
}
220221
})
221222

222-
ginkgo.It("should function for client IP based session affinity: udp", func() {
223+
// [LinuxOnly]: Windows does not support session affinity.
224+
ginkgo.It("should function for client IP based session affinity: udp [LinuxOnly]", func() {
223225
config := framework.NewNetworkingTestConfig(f)
224226
ginkgo.By(fmt.Sprintf("dialing(udp) %v --> %v:%v", config.TestContainerPod.Name, config.SessionAffinityService.Spec.ClusterIP, framework.ClusterUDPPort))
225227

test/e2e/network/service.go

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1804,32 +1804,37 @@ var _ = SIGDescribe("Services", func() {
18041804
}
18051805
})
18061806

1807-
ginkgo.It("should have session affinity work for service with type clusterIP", func() {
1807+
// [LinuxOnly]: Windows does not support session affinity.
1808+
ginkgo.It("should have session affinity work for service with type clusterIP [LinuxOnly]", func() {
18081809
svc := getServeHostnameService("affinity-clusterip")
18091810
svc.Spec.Type = v1.ServiceTypeClusterIP
18101811
execAffinityTestForNonLBService(f, cs, svc)
18111812
})
18121813

1813-
ginkgo.It("should be able to switch session affinity for service with type clusterIP", func() {
1814+
// [LinuxOnly]: Windows does not support session affinity.
1815+
ginkgo.It("should be able to switch session affinity for service with type clusterIP [LinuxOnly]", func() {
18141816
svc := getServeHostnameService("affinity-clusterip-transition")
18151817
svc.Spec.Type = v1.ServiceTypeClusterIP
18161818
execAffinityTestForNonLBServiceWithTransition(f, cs, svc)
18171819
})
18181820

1819-
ginkgo.It("should have session affinity work for NodePort service", func() {
1821+
// [LinuxOnly]: Windows does not support session affinity.
1822+
ginkgo.It("should have session affinity work for NodePort service [LinuxOnly]", func() {
18201823
svc := getServeHostnameService("affinity-nodeport")
18211824
svc.Spec.Type = v1.ServiceTypeNodePort
18221825
execAffinityTestForNonLBService(f, cs, svc)
18231826
})
18241827

1825-
ginkgo.It("should be able to switch session affinity for NodePort service", func() {
1828+
// [LinuxOnly]: Windows does not support session affinity.
1829+
ginkgo.It("should be able to switch session affinity for NodePort service [LinuxOnly]", func() {
18261830
svc := getServeHostnameService("affinity-nodeport-transition")
18271831
svc.Spec.Type = v1.ServiceTypeNodePort
18281832
execAffinityTestForNonLBServiceWithTransition(f, cs, svc)
18291833
})
18301834

18311835
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
1832-
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters]", func() {
1836+
// [LinuxOnly]: Windows does not support session affinity.
1837+
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
18331838
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
18341839
framework.SkipIfProviderIs("aws")
18351840

@@ -1840,7 +1845,8 @@ var _ = SIGDescribe("Services", func() {
18401845
})
18411846

18421847
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
1843-
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters]", func() {
1848+
// [LinuxOnly]: Windows does not support session affinity.
1849+
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
18441850
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
18451851
framework.SkipIfProviderIs("aws")
18461852

@@ -1851,7 +1857,8 @@ var _ = SIGDescribe("Services", func() {
18511857
})
18521858

18531859
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
1854-
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters]", func() {
1860+
// [LinuxOnly]: Windows does not support session affinity.
1861+
ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
18551862
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
18561863
framework.SkipIfProviderIs("aws")
18571864

@@ -1862,7 +1869,8 @@ var _ = SIGDescribe("Services", func() {
18621869
})
18631870

18641871
// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed.
1865-
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters]", func() {
1872+
// [LinuxOnly]: Windows does not support session affinity.
1873+
ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() {
18661874
// L4 load balancer affinity `ClientIP` is not supported on AWS ELB.
18671875
framework.SkipIfProviderIs("aws")
18681876

0 commit comments

Comments
 (0)