Skip to content

Commit f790f0a

Browse files
authored
Merge pull request kubernetes#89364 from zzxwill/master
Explain a little bit on how to prepare Dockerfile before building kube-build image, to avoid confusion.
2 parents f6704fd + a8e6f2c commit f790f0a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ The following scripts are found in the [`build/`](.) directory. Note that all sc
3434

3535
## Basic Flow
3636

37-
The scripts directly under [`build/`](.) are used to build and test. They will ensure that the `kube-build` Docker image is built (based on [`build/build-image/Dockerfile`](build-image/Dockerfile)) and then execute the appropriate command in that container. These scripts will both ensure that the right data is cached from run to run for incremental builds and will copy the results back out of the container.
37+
The scripts directly under [`build/`](.) are used to build and test. They will ensure that the `kube-build` Docker image is built (based on [`build/build-image/Dockerfile`](build-image/Dockerfile) and after base image's `KUBE_BUILD_IMAGE_CROSS_TAG` from Dockerfile is replaced with one of those actual tags of the base image, like `v1.13.9-2`) and then execute the appropriate command in that container. These scripts will both ensure that the right data is cached from run to run for incremental builds and will copy the results back out of the container.
3838

3939
The `kube-build` container image is built by first creating a "context" directory in `_output/images/build-image`. It is done there instead of at the root of the Kubernetes repo to minimize the amount of data we need to package up when building the image.
4040

0 commit comments

Comments
 (0)