Skip to content

Commit f8f6229

Browse files
authored
Merge pull request kubernetes#87950 from tanjunchen/fix-no-non-ascii-characters-/test
test/ : fix non-ascii characters
2 parents 921ef35 + e96b037 commit f8f6229

File tree

9 files changed

+37
-37
lines changed

9 files changed

+37
-37
lines changed

test/e2e/common/configmap_volume.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var _ = ginkgo.Describe("[sig-storage] ConfigMap", func() {
4848
/*
4949
Release : v1.9
5050
Testname: ConfigMap Volume, without mapping, volume mode set
51-
Description: Create a ConfigMap, create a Pod that mounts a volume and populates the volume with data stored in the ConfigMap. File mode is changed to a custom value of '0x400'. The ConfigMap that is created MUST be accessible to read from the newly created Pod using the volume mount. The data content of the file MUST be readable and verified and file modes MUST be set to the custom value of 0x400
51+
Description: Create a ConfigMap, create a Pod that mounts a volume and populates the volume with data stored in the ConfigMap. File mode is changed to a custom value of '0x400'. The ConfigMap that is created MUST be accessible to read from the newly created Pod using the volume mount. The data content of the file MUST be readable and verified and file modes MUST be set to the custom value of '0x400'
5252
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
5353
*/
5454
framework.ConformanceIt("should be consumable from pods in volume with defaultMode set [LinuxOnly] [NodeConformance]", func() {
@@ -90,7 +90,7 @@ var _ = ginkgo.Describe("[sig-storage] ConfigMap", func() {
9090
/*
9191
Release : v1.9
9292
Testname: ConfigMap Volume, with mapping, volume mode set
93-
Description: Create a ConfigMap, create a Pod that mounts a volume and populates the volume with data stored in the ConfigMap. Files are mapped to a path in the volume. File mode is changed to a custom value of '0x400'. The ConfigMap that is created MUST be accessible to read from the newly created Pod using the volume mount. The data content of the file MUST be readable and verified and file modes MUST be set to the custom value of 0x400
93+
Description: Create a ConfigMap, create a Pod that mounts a volume and populates the volume with data stored in the ConfigMap. Files are mapped to a path in the volume. File mode is changed to a custom value of '0x400'. The ConfigMap that is created MUST be accessible to read from the newly created Pod using the volume mount. The data content of the file MUST be readable and verified and file modes MUST be set to the custom value of '0x400'
9494
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
9595
*/
9696
framework.ConformanceIt("should be consumable from pods in volume with mappings and Item mode set [LinuxOnly] [NodeConformance]", func() {

test/e2e/common/container_probe.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ var _ = framework.KubeDescribe("Probing container", func() {
133133
/*
134134
Release : v1.9
135135
Testname: Pod liveness probe, using local file, no restart
136-
Description: Pod is created with liveness probe that uses exec command to cat /temp/health file. Liveness probe MUST not fail to check health and the restart count should remain 0.
136+
Description: Pod is created with liveness probe that uses 'exec' command to cat /temp/health file. Liveness probe MUST not fail to check health and the restart count should remain 0.
137137
*/
138138
framework.ConformanceIt("should *not* be restarted with a exec \"cat /tmp/health\" liveness probe [NodeConformance]", func() {
139139
cmd := []string{"/bin/sh", "-c", "echo ok >/tmp/health; sleep 600"}
@@ -194,7 +194,7 @@ var _ = framework.KubeDescribe("Probing container", func() {
194194
/*
195195
Release : v1.9
196196
Testname: Pod liveness probe, using http endpoint, failure
197-
Description: A Pod is created with liveness probe on http endpoint ‘/’. Liveness probe on this endpoint will not fail. When liveness probe does not fail then the restart count MUST remain zero.
197+
Description: A Pod is created with liveness probe on http endpoint '/'. Liveness probe on this endpoint will not fail. When liveness probe does not fail then the restart count MUST remain zero.
198198
*/
199199
framework.ConformanceIt("should *not* be restarted with a /healthz http liveness probe [NodeConformance]", func() {
200200
livenessProbe := &v1.Probe{

test/e2e/common/lifecycle_hook.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ var _ = framework.KubeDescribe("Container Lifecycle Hook", func() {
9494
/*
9595
Release : v1.9
9696
Testname: Pod Lifecycle, post start exec hook
97-
Description: When a post start handler is specified in the container lifecycle using a Exec action, then the handler MUST be invoked after the start of the container. A server pod is created that will serve http requests, create a second pod with a container lifecycle specifying a post start that invokes the server pod using ExecAction to validate that the post start is executed.
97+
Description: When a post start handler is specified in the container lifecycle using a 'Exec' action, then the handler MUST be invoked after the start of the container. A server pod is created that will serve http requests, create a second pod with a container lifecycle specifying a post start that invokes the server pod using ExecAction to validate that the post start is executed.
9898
*/
9999
framework.ConformanceIt("should execute poststart exec hook properly [NodeConformance]", func() {
100100
lifecycle := &v1.Lifecycle{
@@ -110,7 +110,7 @@ var _ = framework.KubeDescribe("Container Lifecycle Hook", func() {
110110
/*
111111
Release : v1.9
112112
Testname: Pod Lifecycle, prestop exec hook
113-
Description: When a pre-stop handler is specified in the container lifecycle using a Exec action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve http requests, create a second pod with a container lifecycle specifying a pre-stop that invokes the server pod using ExecAction to validate that the pre-stop is executed.
113+
Description: When a pre-stop handler is specified in the container lifecycle using a 'Exec' action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve http requests, create a second pod with a container lifecycle specifying a pre-stop that invokes the server pod using ExecAction to validate that the pre-stop is executed.
114114
*/
115115
framework.ConformanceIt("should execute prestop exec hook properly [NodeConformance]", func() {
116116
lifecycle := &v1.Lifecycle{
@@ -144,7 +144,7 @@ var _ = framework.KubeDescribe("Container Lifecycle Hook", func() {
144144
/*
145145
Release : v1.9
146146
Testname: Pod Lifecycle, prestop http hook
147-
Description: When a pre-stop handler is specified in the container lifecycle using a HttpGet action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve http requests, create a second pod with a container lifecycle specifying a pre-stop that invokes the server pod to validate that the pre-stop is executed.
147+
Description: When a pre-stop handler is specified in the container lifecycle using a 'HttpGet' action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve http requests, create a second pod with a container lifecycle specifying a pre-stop that invokes the server pod to validate that the pre-stop is executed.
148148
*/
149149
framework.ConformanceIt("should execute prestop http hook properly [NodeConformance]", func() {
150150
lifecycle := &v1.Lifecycle{

test/e2e/common/projected_downwardapi.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected downwardAPI", func() {
6060
/*
6161
Release : v1.9
6262
Testname: Projected Volume, DownwardAPI, volume mode 0400
63-
Description: A Pod is created with a projected volume source for downwardAPI with pod name, cpu and memory limits and cpu and memory requests. The default mode for the volume mount is set to 0400. Pod MUST be able to read the pod name from the mounted DownwardAPIVolumeFiles and the volume mode must be -r—-—————.
63+
Description: A Pod is created with a projected volume source for downwardAPI with pod name, cpu and memory limits and cpu and memory requests. The default mode for the volume mount is set to 0400. Pod MUST be able to read the pod name from the mounted DownwardAPIVolumeFiles and the volume mode must be -r--------.
6464
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
6565
*/
6666
framework.ConformanceIt("should set DefaultMode on files [LinuxOnly] [NodeConformance]", func() {
@@ -76,7 +76,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected downwardAPI", func() {
7676
/*
7777
Release : v1.9
7878
Testname: Projected Volume, DownwardAPI, volume mode 0400
79-
Description: A Pod is created with a projected volume source for downwardAPI with pod name, cpu and memory limits and cpu and memory requests. The default mode for the volume mount is set to 0400. Pod MUST be able to read the pod name from the mounted DownwardAPIVolumeFiles and the volume mode must be -r—-—————.
79+
Description: A Pod is created with a projected volume source for downwardAPI with pod name, cpu and memory limits and cpu and memory requests. The default mode for the volume mount is set to 0400. Pod MUST be able to read the pod name from the mounted DownwardAPIVolumeFiles and the volume mode must be -r--------.
8080
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
8181
*/
8282
framework.ConformanceIt("should set mode on item file [LinuxOnly] [NodeConformance]", func() {

test/e2e/common/projected_secret.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected secret", func() {
3838
/*
3939
Release : v1.9
4040
Testname: Projected Volume, Secrets, volume mode default
41-
Description: A Pod is created with a projected volume source secret to store a secret with a specified key with default permission mode. Pod MUST be able to read the content of the key successfully and the mode MUST be -rw-r--r-- by default.
41+
Description: A Pod is created with a projected volume source 'secret' to store a secret with a specified key with default permission mode. Pod MUST be able to read the content of the key successfully and the mode MUST be -rw-r--r-- by default.
4242
*/
4343
framework.ConformanceIt("should be consumable from pods in volume [NodeConformance]", func() {
4444
doProjectedSecretE2EWithoutMapping(f, nil /* default mode */, "projected-secret-test-"+string(uuid.NewUUID()), nil, nil)
@@ -47,7 +47,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected secret", func() {
4747
/*
4848
Release : v1.9
4949
Testname: Projected Volume, Secrets, volume mode 0400
50-
Description: A Pod is created with a projected volume source secret to store a secret with a specified key with permission mode set to 0x400 on the Pod. Pod MUST be able to read the content of the key successfully and the mode MUST be -r—-—————.
50+
Description: A Pod is created with a projected volume source 'secret' to store a secret with a specified key with permission mode set to 0x400 on the Pod. Pod MUST be able to read the content of the key successfully and the mode MUST be -r--------.
5151
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
5252
*/
5353
framework.ConformanceIt("should be consumable from pods in volume with defaultMode set [LinuxOnly] [NodeConformance]", func() {
@@ -58,7 +58,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected secret", func() {
5858
/*
5959
Release : v1.9
6060
Testname: Project Volume, Secrets, non-root, custom fsGroup
61-
Description: A Pod is created with a projected volume source secret to store a secret with a specified key. The volume has permission mode set to 0440, fsgroup set to 1001 and user set to non-root uid of 1000. Pod MUST be able to read the content of the key successfully and the mode MUST be -r—-r————-.
61+
Description: A Pod is created with a projected volume source 'secret' to store a secret with a specified key. The volume has permission mode set to 0440, fsgroup set to 1001 and user set to non-root uid of 1000. Pod MUST be able to read the content of the key successfully and the mode MUST be -r--r-----.
6262
This test is marked LinuxOnly since Windows does not support setting specific file permissions, or running as UID / GID.
6363
*/
6464
framework.ConformanceIt("should be consumable from pods in volume as non-root with defaultMode and fsGroup set [LinuxOnly] [NodeConformance]", func() {
@@ -70,7 +70,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected secret", func() {
7070
/*
7171
Release : v1.9
7272
Testname: Projected Volume, Secrets, mapped
73-
Description: A Pod is created with a projected volume source secret to store a secret with a specified key with default permission mode. The secret is also mapped to a custom path. Pod MUST be able to read the content of the key successfully and the mode MUST be -r—-—————— on the mapped volume.
73+
Description: A Pod is created with a projected volume source 'secret' to store a secret with a specified key with default permission mode. The secret is also mapped to a custom path. Pod MUST be able to read the content of the key successfully and the mode MUST be -r--------on the mapped volume.
7474
*/
7575
framework.ConformanceIt("should be consumable from pods in volume with mappings [NodeConformance]", func() {
7676
doProjectedSecretE2EWithMapping(f, nil)
@@ -79,7 +79,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected secret", func() {
7979
/*
8080
Release : v1.9
8181
Testname: Projected Volume, Secrets, mapped, volume mode 0400
82-
Description: A Pod is created with a projected volume source secret to store a secret with a specified key with permission mode set to 0400. The secret is also mapped to a specific name. Pod MUST be able to read the content of the key successfully and the mode MUST be -r—-—————— on the mapped volume.
82+
Description: A Pod is created with a projected volume source 'secret' to store a secret with a specified key with permission mode set to 0400. The secret is also mapped to a specific name. Pod MUST be able to read the content of the key successfully and the mode MUST be -r-------- on the mapped volume.
8383
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
8484
*/
8585
framework.ConformanceIt("should be consumable from pods in volume with mappings and Item Mode set [LinuxOnly] [NodeConformance]", func() {
@@ -111,7 +111,7 @@ var _ = ginkgo.Describe("[sig-storage] Projected secret", func() {
111111
/*
112112
Release : v1.9
113113
Testname: Projected Volume, Secrets, mapped, multiple paths
114-
Description: A Pod is created with a projected volume source secret to store a secret with a specified key. The secret is mapped to two different volume mounts. Pod MUST be able to read the content of the key successfully from the two volume mounts and the mode MUST be -r—-—————— on the mapped volumes.
114+
Description: A Pod is created with a projected volume source 'secret' to store a secret with a specified key. The secret is mapped to two different volume mounts. Pod MUST be able to read the content of the key successfully from the two volume mounts and the mode MUST be -r-------- on the mapped volumes.
115115
*/
116116
framework.ConformanceIt("should be consumable in multiple volumes in a pod [NodeConformance]", func() {
117117
// This test ensures that the same secret can be mounted in multiple

test/e2e/common/secrets.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ var _ = ginkgo.Describe("[sig-api-machinery] Secrets", func() {
8787
/*
8888
Release : v1.9
8989
Testname: Secrets, pod environment from source
90-
Description: Create a secret. Create a Pod with Container that declares a environment variable using EnvFrom which references the secret created to extract a key value from the secret. Pod MUST have the environment variable that contains proper value for the key to the secret.
90+
Description: Create a secret. Create a Pod with Container that declares a environment variable using 'EnvFrom' which references the secret created to extract a key value from the secret. Pod MUST have the environment variable that contains proper value for the key to the secret.
9191
*/
9292
framework.ConformanceIt("should be consumable via the environment [NodeConformance]", func() {
9393
name := "secret-test-" + string(uuid.NewUUID())

test/e2e/common/secrets_volume.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var _ = ginkgo.Describe("[sig-storage] Secrets", func() {
4848
/*
4949
Release : v1.9
5050
Testname: Secrets Volume, volume mode 0400
51-
Description: Create a secret. Create a Pod with secret volume source configured into the container with file mode set to 0x400. Pod MUST be able to read the secret from the mounted volume from the container runtime and the file mode of the secret MUST be -r——--—-—- by default.
51+
Description: Create a secret. Create a Pod with secret volume source configured into the container with file mode set to 0x400. Pod MUST be able to read the secret from the mounted volume from the container runtime and the file mode of the secret MUST be -r-------- by default.
5252
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
5353
*/
5454
framework.ConformanceIt("should be consumable from pods in volume with defaultMode set [LinuxOnly] [NodeConformance]", func() {
@@ -59,7 +59,7 @@ var _ = ginkgo.Describe("[sig-storage] Secrets", func() {
5959
/*
6060
Release : v1.9
6161
Testname: Secrets Volume, volume mode 0440, fsGroup 1001 and uid 1000
62-
Description: Create a secret. Create a Pod with secret volume source configured into the container with file mode set to 0x440 as a non-root user with uid 1000 and fsGroup id 1001. Pod MUST be able to read the secret from the mounted volume from the container runtime and the file mode of the secret MUST be -r——r-—-—- by default.
62+
Description: Create a secret. Create a Pod with secret volume source configured into the container with file mode set to 0x440 as a non-root user with uid 1000 and fsGroup id 1001. Pod MUST be able to read the secret from the mounted volume from the container runtime and the file mode of the secret MUST be -r--r-----by default.
6363
This test is marked LinuxOnly since Windows does not support setting specific file permissions, or running as UID / GID.
6464
*/
6565
framework.ConformanceIt("should be consumable from pods in volume as non-root with defaultMode and fsGroup set [LinuxOnly] [NodeConformance]", func() {
@@ -71,7 +71,7 @@ var _ = ginkgo.Describe("[sig-storage] Secrets", func() {
7171
/*
7272
Release : v1.9
7373
Testname: Secrets Volume, mapping
74-
Description: Create a secret. Create a Pod with secret volume source configured into the container with a custom path. Pod MUST be able to read the secret from the mounted volume from the specified custom path. The file mode of the secret MUST be -rw—r-—r—- by default.
74+
Description: Create a secret. Create a Pod with secret volume source configured into the container with a custom path. Pod MUST be able to read the secret from the mounted volume from the specified custom path. The file mode of the secret MUST be -rw-r--r-- by default.
7575
*/
7676
framework.ConformanceIt("should be consumable from pods in volume with mappings [NodeConformance]", func() {
7777
doSecretE2EWithMapping(f, nil)
@@ -80,7 +80,7 @@ var _ = ginkgo.Describe("[sig-storage] Secrets", func() {
8080
/*
8181
Release : v1.9
8282
Testname: Secrets Volume, mapping, volume mode 0400
83-
Description: Create a secret. Create a Pod with secret volume source configured into the container with a custom path and file mode set to 0x400. Pod MUST be able to read the secret from the mounted volume from the specified custom path. The file mode of the secret MUST be -r-—r-—r—-.
83+
Description: Create a secret. Create a Pod with secret volume source configured into the container with a custom path and file mode set to 0x400. Pod MUST be able to read the secret from the mounted volume from the specified custom path. The file mode of the secret MUST be -r--r--r--.
8484
This test is marked LinuxOnly since Windows does not support setting specific file permissions.
8585
*/
8686
framework.ConformanceIt("should be consumable from pods in volume with mappings and Item Mode set [LinuxOnly] [NodeConformance]", func() {

test/e2e/framework/config/config_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,18 @@ func TestInt(t *testing.T) {
4747
func TestLower(t *testing.T) {
4848
flags := flag.NewFlagSet("test", 0)
4949
var context struct {
50-
Ähem string
50+
Ahem string
5151
MixedCase string
5252
}
5353
require.NotPanics(t, func() {
5454
AddOptionsToSet(flags, &context, "")
5555
})
5656
require.Equal(t, []simpleFlag{
5757
{
58-
name: "mixedCase",
58+
name: "ahem",
5959
},
6060
{
61-
name: "ähem",
61+
name: "mixedCase",
6262
},
6363
},
6464
allFlags(flags))

0 commit comments

Comments
 (0)