Skip to content

Commit f90bbc3

Browse files
committed
src/k8s.io/apiserver: Increase cert expiration histogram resolution
The `certificate_expiration_seconds` histogram measures the remaining time of client certificates used to authenticate to the API server. It records the lifetime of received client request certificates in buckets of 6h, 12h, ..., 1y. In environments with automated certificate rotation it is not uncommen to have issued certificates expire in less than the above mentioned minimum bucket of 6h. In such environments the above histogram is useless given that every request will be recorded in the first bucket. This patch increases the histogram resolution by adding a 30m, 1h and 2h bucket. Prometheus histogram buckets are cummulative, e.g. the 12h bucket is counting _all_ records with an expiration date lower or equal to 12h including _all_ requests of the 6h bucket. Thereby this patch does not break existing monitoring setups. This histogram is exposed once per API server, thereby the 3 additional time series do not cause a cardinality issue.
1 parent e9b285a commit f90bbc3

File tree

1 file changed

+3
-0
lines changed
  • staging/src/k8s.io/apiserver/pkg/authentication/request/x509

1 file changed

+3
-0
lines changed

staging/src/k8s.io/apiserver/pkg/authentication/request/x509/x509.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ var clientCertificateExpirationHistogram = prometheus.NewHistogram(
3939
Help: "Distribution of the remaining lifetime on the certificate used to authenticate a request.",
4040
Buckets: []float64{
4141
0,
42+
(30 * time.Minute).Seconds(),
43+
(1 * time.Hour).Seconds(),
44+
(2 * time.Hour).Seconds(),
4245
(6 * time.Hour).Seconds(),
4346
(12 * time.Hour).Seconds(),
4447
(24 * time.Hour).Seconds(),

0 commit comments

Comments
 (0)