Skip to content

Commit fad8f53

Browse files
authored
Merge pull request kubernetes#81993 from hwdef/fix-test/e2e/gke_node_pools.go
fix test/e2e/gke_node_pools.go
2 parents 85602f2 + 3035943 commit fad8f53

File tree

1 file changed

+19
-20
lines changed

1 file changed

+19
-20
lines changed

test/e2e/gke_node_pools.go

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121
"os/exec"
2222

2323
"k8s.io/kubernetes/test/e2e/framework"
24-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
2524

2625
"github.com/onsi/ginkgo"
2726
)
@@ -35,64 +34,64 @@ var _ = framework.KubeDescribe("GKE node pools [Feature:GKENodePool]", func() {
3534
})
3635

3736
ginkgo.It("should create a cluster with multiple node pools [Feature:GKENodePool]", func() {
38-
e2elog.Logf("Start create node pool test")
37+
framework.Logf("Start create node pool test")
3938
testCreateDeleteNodePool(f, "test-pool")
4039
})
4140
})
4241

4342
func testCreateDeleteNodePool(f *framework.Framework, poolName string) {
44-
e2elog.Logf("Create node pool: %q in cluster: %q", poolName, framework.TestContext.CloudConfig.Cluster)
43+
framework.Logf("Create node pool: %q in cluster: %q", poolName, framework.TestContext.CloudConfig.Cluster)
4544

4645
clusterStr := fmt.Sprintf("--cluster=%s", framework.TestContext.CloudConfig.Cluster)
4746

4847
out, err := exec.Command("gcloud", "container", "node-pools", "create",
4948
poolName,
5049
clusterStr,
5150
"--num-nodes=2").CombinedOutput()
52-
e2elog.Logf("\n%s", string(out))
51+
framework.Logf("\n%s", string(out))
5352
if err != nil {
54-
e2elog.Failf("Failed to create node pool %q. Err: %v\n%v", poolName, err, string(out))
53+
framework.Failf("Failed to create node pool %q. Err: %v\n%v", poolName, err, string(out))
5554
}
56-
e2elog.Logf("Successfully created node pool %q.", poolName)
55+
framework.Logf("Successfully created node pool %q.", poolName)
5756

5857
out, err = exec.Command("gcloud", "container", "node-pools", "list",
5958
clusterStr).CombinedOutput()
6059
if err != nil {
61-
e2elog.Failf("Failed to list node pools from cluster %q. Err: %v\n%v", framework.TestContext.CloudConfig.Cluster, err, string(out))
60+
framework.Failf("Failed to list node pools from cluster %q. Err: %v\n%v", framework.TestContext.CloudConfig.Cluster, err, string(out))
6261
}
63-
e2elog.Logf("Node pools:\n%s", string(out))
62+
framework.Logf("Node pools:\n%s", string(out))
6463

65-
e2elog.Logf("Checking that 2 nodes have the correct node pool label.")
64+
framework.Logf("Checking that 2 nodes have the correct node pool label.")
6665
nodeCount := nodesWithPoolLabel(f, poolName)
6766
if nodeCount != 2 {
68-
e2elog.Failf("Wanted 2 nodes with node pool label, got: %v", nodeCount)
67+
framework.Failf("Wanted 2 nodes with node pool label, got: %v", nodeCount)
6968
}
70-
e2elog.Logf("Success, found 2 nodes with correct node pool labels.")
69+
framework.Logf("Success, found 2 nodes with correct node pool labels.")
7170

72-
e2elog.Logf("Deleting node pool: %q in cluster: %q", poolName, framework.TestContext.CloudConfig.Cluster)
71+
framework.Logf("Deleting node pool: %q in cluster: %q", poolName, framework.TestContext.CloudConfig.Cluster)
7372
out, err = exec.Command("gcloud", "container", "node-pools", "delete",
7473
poolName,
7574
clusterStr,
7675
"-q").CombinedOutput()
77-
e2elog.Logf("\n%s", string(out))
76+
framework.Logf("\n%s", string(out))
7877
if err != nil {
79-
e2elog.Failf("Failed to delete node pool %q. Err: %v\n%v", poolName, err, string(out))
78+
framework.Failf("Failed to delete node pool %q. Err: %v\n%v", poolName, err, string(out))
8079
}
81-
e2elog.Logf("Successfully deleted node pool %q.", poolName)
80+
framework.Logf("Successfully deleted node pool %q.", poolName)
8281

8382
out, err = exec.Command("gcloud", "container", "node-pools", "list",
8483
clusterStr).CombinedOutput()
8584
if err != nil {
86-
e2elog.Failf("\nFailed to list node pools from cluster %q. Err: %v\n%v", framework.TestContext.CloudConfig.Cluster, err, string(out))
85+
framework.Failf("\nFailed to list node pools from cluster %q. Err: %v\n%v", framework.TestContext.CloudConfig.Cluster, err, string(out))
8786
}
88-
e2elog.Logf("\nNode pools:\n%s", string(out))
87+
framework.Logf("\nNode pools:\n%s", string(out))
8988

90-
e2elog.Logf("Checking that no nodes have the deleted node pool's label.")
89+
framework.Logf("Checking that no nodes have the deleted node pool's label.")
9190
nodeCount = nodesWithPoolLabel(f, poolName)
9291
if nodeCount != 0 {
93-
e2elog.Failf("Wanted 0 nodes with node pool label, got: %v", nodeCount)
92+
framework.Failf("Wanted 0 nodes with node pool label, got: %v", nodeCount)
9493
}
95-
e2elog.Logf("Success, found no nodes with the deleted node pool's label.")
94+
framework.Logf("Success, found no nodes with the deleted node pool's label.")
9695
}
9796

9897
// nodesWithPoolLabel returns the number of nodes that have the "gke-nodepool"

0 commit comments

Comments
 (0)