Skip to content

Commit fbc28fd

Browse files
authored
Merge pull request kubernetes#76280 from xichengliudui/fixshellcheck0409
Fix shellcheck failures in update-workspace-mirror.sh
2 parents fa9b36d + 961f162 commit fbc28fd

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

hack/.shellcheck_failures

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
./hack/update-translations.sh
5454
./hack/update-vendor-licenses.sh
5555
./hack/update-vendor.sh
56-
./hack/update-workspace-mirror.sh
5756
./hack/verify-api-groups.sh
5857
./hack/verify-boilerplate.sh
5958
./hack/verify-cli-conventions.sh

hack/update-workspace-mirror.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ BUCKET="gs://k8s-bazel-cache"
2929
gsutil acl get "${BUCKET}" > /dev/null
3030

3131
tmpfile=$(mktemp bazel_workspace_mirror.XXXXXX)
32-
trap "rm ${tmpfile}" EXIT
33-
cat "$1" | while read url; do
32+
trap 'rm ${tmpfile}' EXIT
33+
while read -r url; do
3434
echo "${url}"
3535
if gsutil ls "${BUCKET}/${url}" &> /dev/null; then
3636
echo present
@@ -40,4 +40,4 @@ cat "$1" | while read url; do
4040
gsutil cp -a public-read "${tmpfile}" "${BUCKET}/${url}"
4141
fi
4242
fi
43-
done
43+
done < "$1"

0 commit comments

Comments
 (0)