Skip to content

Commit fc8ea98

Browse files
committed
kubelet: rename HTTPGetter interface
1 parent 5cc945a commit fc8ea98

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

pkg/kubelet/kuberuntime/kuberuntime_manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ func NewKubeGenericRuntimeManager(
156156
podStateProvider podStateProvider,
157157
osInterface kubecontainer.OSInterface,
158158
runtimeHelper kubecontainer.RuntimeHelper,
159-
httpClient types.HttpGetter,
159+
httpClient types.HTTPGetter,
160160
imageBackOff *flowcontrol.Backoff,
161161
serializeImagePulls bool,
162162
imagePullQPS float32,

pkg/kubelet/lifecycle/handlers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const (
3838
)
3939

4040
type HandlerRunner struct {
41-
httpGetter kubetypes.HttpGetter
41+
httpGetter kubetypes.HTTPGetter
4242
commandRunner kubecontainer.ContainerCommandRunner
4343
containerManager podStatusProvider
4444
}
@@ -47,7 +47,7 @@ type podStatusProvider interface {
4747
GetPodStatus(uid types.UID, name, namespace string) (*kubecontainer.PodStatus, error)
4848
}
4949

50-
func NewHandlerRunner(httpGetter kubetypes.HttpGetter, commandRunner kubecontainer.ContainerCommandRunner, containerManager podStatusProvider) kubecontainer.HandlerRunner {
50+
func NewHandlerRunner(httpGetter kubetypes.HTTPGetter, commandRunner kubecontainer.ContainerCommandRunner, containerManager podStatusProvider) kubecontainer.HandlerRunner {
5151
return &HandlerRunner{
5252
httpGetter: httpGetter,
5353
commandRunner: commandRunner,

pkg/kubelet/types/types.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ import (
2626

2727
// TODO: Reconcile custom types in kubelet/types and this subpackage
2828

29-
type HttpGetter interface {
29+
// HTTPGetter is an interface representing the ability to perform HTTP GET requests.
30+
type HTTPGetter interface {
31+
// Get issues a GET to the specified URL.
3032
Get(url string) (*http.Response, error)
3133
}
3234

0 commit comments

Comments
 (0)