Skip to content

Commit ffb7573

Browse files
authored
Merge pull request kubernetes#81674 from msau42/use-podutil
Use VisitContainers instead of directly accessing pod container fields
2 parents 9ac0c59 + fa822f3 commit ffb7573

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

pkg/volume/util/util.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
clientset "k8s.io/client-go/kubernetes"
3737
"k8s.io/klog"
3838
"k8s.io/kubernetes/pkg/api/legacyscheme"
39+
podutil "k8s.io/kubernetes/pkg/api/v1/pod"
3940
v1helper "k8s.io/kubernetes/pkg/apis/core/v1/helper"
4041
"k8s.io/kubernetes/pkg/features"
4142
"k8s.io/kubernetes/pkg/util/mount"
@@ -555,13 +556,7 @@ func GetPodVolumeNames(pod *v1.Pod) (mounts sets.String, devices sets.String) {
555556
mounts = sets.NewString()
556557
devices = sets.NewString()
557558

558-
addContainerVolumes(pod.Spec.Containers, mounts, devices)
559-
addContainerVolumes(pod.Spec.InitContainers, mounts, devices)
560-
return
561-
}
562-
563-
func addContainerVolumes(containers []v1.Container, mounts, devices sets.String) {
564-
for _, container := range containers {
559+
podutil.VisitContainers(&pod.Spec, func(container *v1.Container) bool {
565560
if container.VolumeMounts != nil {
566561
for _, mount := range container.VolumeMounts {
567562
mounts.Insert(mount.Name)
@@ -574,5 +569,7 @@ func addContainerVolumes(containers []v1.Container, mounts, devices sets.String)
574569
devices.Insert(device.Name)
575570
}
576571
}
577-
}
572+
return true
573+
})
574+
return
578575
}

0 commit comments

Comments
 (0)