Skip to content

Commit b047d6e

Browse files
Create Data Set action descriptions added for accessibility (#4080)
* add descriptions to create ds actions for accessibility Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * changelog entry Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * add gh issue to changelog entry Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
1 parent 76b0d8e commit b047d6e

File tree

4 files changed

+51
-7
lines changed

4 files changed

+51
-7
lines changed

packages/zowe-explorer/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
2020
- Fixed an issue where an error appeared when moving an empty PDS across LPARs. [#4001](https://github.com/zowe/zowe-explorer-vscode/pull/4001)
2121
- Fixed an issue where logical record length truncation detection failed for extenders. [#4002](https://github.com/zowe/zowe-explorer-vscode/pull/4002)
2222
- Fixed an issue with the "Create New Data Set" feature where a data set attribute's original value was deleted after the user dismissed the input box. Now, the attribute's value is preserved when the user cancels their input. [#4003](https://github.com/zowe/zowe-explorer-vscode/issues/4003)
23+
- Fixed an accessibility issue in the "Create New Data Set" flow by replacing click-oriented instructions with clearer keyboard- and screen reader-friendly prompts and step titles. [#4026](https://github.com/zowe/zowe-explorer-vscode/issues/4026)
2324
- Fixed an issue where the data set sort persistence was overriding the selected sort direction. [#4048](https://github.com/zowe/zowe-explorer-vscode/pull/4048)
2425
- Updated Zowe SDKs to `8.30.1` for technical currency. [#4079](https://github.com/zowe/zowe-explorer-vscode/pull/4079)
2526

packages/zowe-explorer/l10n/bundle.l10n.json

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@
350350
"Clear filter for PDS": "Clear filter for PDS",
351351
"Clear filter for profile": "Clear filter for profile",
352352
"Click on Edit in settings.json to enter in desired values in the file. Specify the method and direction from the options provided by IntelliSense. For example:": "Click on Edit in settings.json to enter in desired values in the file. Specify the method and direction from the options provided by IntelliSense. For example:",
353-
"Click on parameters to change them": "Click on parameters to change them",
354353
"Command response: {0}/Command response": {
355354
"message": "Command response: {0}",
356355
"comment": [
@@ -379,9 +378,15 @@
379378
"Create a new filter. For example: HLQ.*, HLQ.aaa.bbb, HLQ.ccc.ddd(member)": "Create a new filter. For example: HLQ.*, HLQ.aaa.bbb, HLQ.ccc.ddd(member)",
380379
"Create a new MVS command": "Create a new MVS command",
381380
"Create a new TSO command": "Create a new TSO command",
381+
"Create Data Set: Edit Attributes": "Create Data Set: Edit Attributes",
382+
"Create Data Set: Name": "Create Data Set: Name",
383+
"Create Data Set: Review Attributes": "Create Data Set: Review Attributes",
384+
"Create Data Set: Type": "Create Data Set: Type",
385+
"Create Data Set: Update Attribute Value": "Create Data Set: Update Attribute Value",
382386
"Create job search filter": "Create job search filter",
383387
"Create New": "Create New",
384388
"Create new...": "Create new...",
389+
"Create the data set using the current attributes": "Create the data set using the current attributes",
385390
"Creating new data set member {0}/Data Set member name": {
386391
"message": "Creating new data set member {0}",
387392
"comment": [
@@ -505,6 +510,7 @@
505510
"Enter a block size": "Enter a block size",
506511
"Enter a codepage (e.g., 1047, IBM-1047)": "Enter a codepage (e.g., 1047, IBM-1047)",
507512
"Enter a data set name": "Enter a data set name",
513+
"Enter a data set name, then press Enter to continue": "Enter a data set name, then press Enter to continue",
508514
"Enter a dataset pattern to search for": "Enter a dataset pattern to search for",
509515
"Enter a device type (unit)": "Enter a device type (unit)",
510516
"Enter a filter": "Enter a filter",
@@ -518,6 +524,12 @@
518524
]
519525
},
520526
"Enter a valid data set name.": "Enter a valid data set name.",
527+
"Enter a value for {0}, then press Enter to continue/Attribute label": {
528+
"message": "Enter a value for {0}, then press Enter to continue",
529+
"comment": [
530+
"Attribute label"
531+
]
532+
},
521533
"Enter a value to filter by": "Enter a value to filter by",
522534
"Enter an allocation unit": "Enter an allocation unit",
523535
"Enter an SMS data class": "Enter an SMS data class",
@@ -861,6 +873,7 @@
861873
"Fixed an issue where editing a team config file or updating secrets in the OS credential vault could trigger multiple events for a single action. <a>#3296</a>": "Fixed an issue where editing a team config file or updating secrets in the OS credential vault could trigger multiple events for a single action. <a>#3296</a>",
862874
"Fixed an issue where favorites for extender profile types were duplicated in the tree views. <a>#3548</a>": "Fixed an issue where favorites for extender profile types were duplicated in the tree views. <a>#3548</a>",
863875
"Fixed an issue where fetching a USS file using UssFSProvider.stat() with a fetch=true query would cause Zowe Explorer to get stuck in an infinite loop. <a>#3321</a>": "Fixed an issue where fetching a USS file using UssFSProvider.stat() with a fetch=true query would cause Zowe Explorer to get stuck in an infinite loop. <a>#3321</a>",
876+
"Fixed an issue where files opened via extender profiles failed to refresh or reload correctly. <a>#4049</a>": "Fixed an issue where files opened via extender profiles failed to refresh or reload correctly. <a>#4049</a>",
864877
"Fixed an issue where listing data sets resulted in an error after opening a data set with an encoding. <a>#3347</a>": "Fixed an issue where listing data sets resulted in an error after opening a data set with an encoding. <a>#3347</a>",
865878
"Fixed an issue where loading of virtual workspaces interfered with the activation of some Zowe Explorer extensions. <a>#3923</a>": "Fixed an issue where loading of virtual workspaces interfered with the activation of some Zowe Explorer extensions. <a>#3923</a>",
866879
"Fixed an issue where logical record length truncation detection failed for extenders. <a>#4002</a>": "Fixed an issue where logical record length truncation detection failed for extenders. <a>#4002</a>",
@@ -1725,6 +1738,8 @@
17251738
"Current work directory"
17261739
]
17271740
},
1741+
"Select Allocate Data Set to create now, or Edit Attributes to review values": "Select Allocate Data Set to create now, or Edit Attributes to review values",
1742+
"Select an attribute to edit, or select Allocate Data Set to create the data set": "Select an attribute to edit, or select Allocate Data Set to create the data set",
17281743
"Select an item before deleting": "Select an item before deleting",
17291744
"Select an MVS command to run against {0} (An option to edit will follow)/Host name": {
17301745
"message": "Select an MVS command to run against {0} (An option to edit will follow)",
@@ -2007,7 +2022,7 @@
20072022
"Updated Zowe SDKs to 8.16.0 to include the latest enhancements from Imperative and the z/OS Files SDK. <a>#3526</a>": "Updated Zowe SDKs to 8.16.0 to include the latest enhancements from Imperative and the z/OS Files SDK. <a>#3526</a>",
20082023
"Updated Zowe SDKs to 8.21.0 for technical currency. <a>#3668</a>": "Updated Zowe SDKs to 8.21.0 for technical currency. <a>#3668</a>",
20092024
"Updated Zowe SDKs to 8.26.1 for technical currency. <a>#3696</a>": "Updated Zowe SDKs to 8.26.1 for technical currency. <a>#3696</a>",
2010-
"Updated Zowe SDKs to 8.29.9 for technical currency. <a>#4040</a>": "Updated Zowe SDKs to 8.29.9 for technical currency. <a>#4040</a>",
2025+
"Updated Zowe SDKs to 8.30.1 for technical currency. <a>#4079</a>": "Updated Zowe SDKs to 8.30.1 for technical currency. <a>#4079</a>",
20112026
"Updated Zowe SDKs to version 8.28.0 to address an issue where copying a PDS member to a data set across LPARs failed. This occurred when the target PDS already contained members, but none matched the name of the PDS member being copied. <a>#3848</a>": "Updated Zowe SDKs to version 8.28.0 to address an issue where copying a PDS member to a data set across LPARs failed. This occurred when the target PDS already contained members, but none matched the name of the PDS member being copied. <a>#3848</a>",
20122027
"Updating data set templates.": "Updating data set templates.",
20132028
"Updating imperative.json credential manager to {0}.\n{1}/Default credential override settingNew credential override setting": {

packages/zowe-explorer/l10n/poeditor.json

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,6 @@
835835
"Clear filter for PDS": "",
836836
"Clear filter for profile": "",
837837
"Click on Edit in settings.json to enter in desired values in the file. Specify the method and direction from the options provided by IntelliSense. For example:": "",
838-
"Click on parameters to change them": "",
839838
"Command response: {0}": "",
840839
"Common API": "",
841840
"Config File: ": "",
@@ -854,9 +853,15 @@
854853
"Create a new filter. For example: HLQ.*, HLQ.aaa.bbb, HLQ.ccc.ddd(member)": "",
855854
"Create a new MVS command": "",
856855
"Create a new TSO command": "",
856+
"Create Data Set: Edit Attributes": "",
857+
"Create Data Set: Name": "",
858+
"Create Data Set: Review Attributes": "",
859+
"Create Data Set: Type": "",
860+
"Create Data Set: Update Attribute Value": "",
857861
"Create job search filter": "",
858862
"Create New": "",
859863
"Create new...": "",
864+
"Create the data set using the current attributes": "",
860865
"Creating new data set member {0}": "",
861866
"Creation Date": "",
862867
"Credential Manager Updates": "",
@@ -929,6 +934,7 @@
929934
"Enter a block size": "",
930935
"Enter a codepage (e.g., 1047, IBM-1047)": "",
931936
"Enter a data set name": "",
937+
"Enter a data set name, then press Enter to continue": "",
932938
"Enter a dataset pattern to search for": "",
933939
"Enter a device type (unit)": "",
934940
"Enter a filter": "",
@@ -937,6 +943,7 @@
937943
"Enter a name for the new data set": "",
938944
"Enter a new name for the {0}": "",
939945
"Enter a valid data set name.": "",
946+
"Enter a value for {0}, then press Enter to continue": "",
940947
"Enter a value to filter by": "",
941948
"Enter an allocation unit": "",
942949
"Enter an SMS data class": "",
@@ -1082,6 +1089,7 @@
10821089
"Fixed an issue where editing a team config file or updating secrets in the OS credential vault could trigger multiple events for a single action. <a>#3296</a>": "",
10831090
"Fixed an issue where favorites for extender profile types were duplicated in the tree views. <a>#3548</a>": "",
10841091
"Fixed an issue where fetching a USS file using UssFSProvider.stat() with a fetch=true query would cause Zowe Explorer to get stuck in an infinite loop. <a>#3321</a>": "",
1092+
"Fixed an issue where files opened via extender profiles failed to refresh or reload correctly. <a>#4049</a>": "",
10851093
"Fixed an issue where listing data sets resulted in an error after opening a data set with an encoding. <a>#3347</a>": "",
10861094
"Fixed an issue where loading of virtual workspaces interfered with the activation of some Zowe Explorer extensions. <a>#3923</a>": "",
10871095
"Fixed an issue where logical record length truncation detection failed for extenders. <a>#4002</a>": "",
@@ -1639,6 +1647,8 @@
16391647
"Select a TSO command to run immediately against {0}": "",
16401648
"Select a Unix command to run against {0} (An option to edit will follow)": "",
16411649
"Select a Unix command to run immediately against {0}": "",
1650+
"Select Allocate Data Set to create now, or Edit Attributes to review values": "",
1651+
"Select an attribute to edit, or select Allocate Data Set to create the data set": "",
16421652
"Select an item before deleting": "",
16431653
"Select an MVS command to run against {0} (An option to edit will follow)": "",
16441654
"Select an MVS command to run immediately against {0}": "",
@@ -1800,7 +1810,7 @@
18001810
"Updated Zowe SDKs to 8.16.0 to include the latest enhancements from Imperative and the z/OS Files SDK. <a>#3526</a>": "",
18011811
"Updated Zowe SDKs to 8.21.0 for technical currency. <a>#3668</a>": "",
18021812
"Updated Zowe SDKs to 8.26.1 for technical currency. <a>#3696</a>": "",
1803-
"Updated Zowe SDKs to 8.29.9 for technical currency. <a>#4040</a>": "",
1813+
"Updated Zowe SDKs to 8.30.1 for technical currency. <a>#4079</a>": "",
18041814
"Updated Zowe SDKs to version 8.28.0 to address an issue where copying a PDS member to a data set across LPARs failed. This occurred when the target PDS already contained members, but none matched the name of the PDS member being copied. <a>#3848</a>": "",
18051815
"Updating data set templates.": "",
18061816
"Updating imperative.json credential manager to {0}.\n{1}": "",

packages/zowe-explorer/src/trees/dataset/DatasetActions.ts

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,25 @@ export class DatasetActions {
7474
private static async handleUserSelection(): Promise<string> {
7575
// Create the array of items in the quickpick list
7676
const qpItems = [];
77-
qpItems.push(new FilterItem({ text: `\u002B ${DatasetActions.localizedStrings.allocString}`, show: true }));
77+
qpItems.push(
78+
new FilterItem({
79+
text: `\u002B ${DatasetActions.localizedStrings.allocString}`,
80+
description: vscode.l10n.t("Create the data set using the current attributes"),
81+
show: true,
82+
})
83+
);
7884
DatasetActions.newDSProperties?.forEach((prop) => {
7985
const propLabel = `\u270F ${prop.label as string}`;
8086
qpItems.push(new FilterItem({ text: propLabel, description: prop.value, show: true }));
8187
});
8288

8389
// Provide the settings for the quickpick's appearance & behavior
8490
const quickpick = Gui.createQuickPick();
85-
quickpick.placeholder = vscode.l10n.t("Click on parameters to change them");
91+
quickpick.title = vscode.l10n.t("Create Data Set: Edit Attributes");
92+
quickpick.placeholder = vscode.l10n.t("Select an attribute to edit, or select Allocate Data Set to create the data set");
8693
quickpick.ignoreFocusOut = true;
8794
quickpick.items = [...qpItems];
88-
quickpick.matchOnDescription = false;
95+
quickpick.matchOnDescription = true;
8996
quickpick.onDidHide(() => {
9097
if (quickpick.selectedItems.length === 0) {
9198
ZoweLogger.debug(DatasetActions.localizedStrings.opCancelled);
@@ -104,6 +111,12 @@ export class DatasetActions {
104111
const showPatternOptions = async (): Promise<void> => {
105112
const property = DatasetActions.newDSProperties?.find((prop) => pattern.includes(prop.label));
106113
const options: vscode.InputBoxOptions = {
114+
title: vscode.l10n.t("Create Data Set: Update Attribute Value"),
115+
prompt: vscode.l10n.t({
116+
message: "Enter a value for {0}, then press Enter to continue",
117+
args: [property?.label],
118+
comment: ["Attribute label"],
119+
}),
107120
value: property?.value,
108121
placeHolder: property?.placeHolder,
109122
};
@@ -127,6 +140,8 @@ export class DatasetActions {
127140

128141
private static async getDataSetName(): Promise<string> {
129142
const options: vscode.InputBoxOptions = {
143+
title: vscode.l10n.t("Create Data Set: Name"),
144+
prompt: vscode.l10n.t("Enter a data set name, then press Enter to continue"),
130145
placeHolder: vscode.l10n.t("Name of Data Set"),
131146
ignoreFocusOut: true,
132147
validateInput: (text) => {
@@ -143,6 +158,7 @@ export class DatasetActions {
143158

144159
private static async getDsTypeForCreation(datasetProvider: Types.IZoweDatasetTreeType): Promise<string> {
145160
const stepTwoOptions: vscode.QuickPickOptions = {
161+
title: vscode.l10n.t("Create Data Set: Type"),
146162
placeHolder: vscode.l10n.t("Template of Data Set to be Created"),
147163
ignoreFocusOut: true,
148164
canPickMany: false,
@@ -244,6 +260,8 @@ export class DatasetActions {
244260

245261
private static async allocateOrEditAttributes(): Promise<string> {
246262
const stepThreeOptions: vscode.QuickPickOptions = {
263+
title: vscode.l10n.t("Create Data Set: Review Attributes"),
264+
placeHolder: vscode.l10n.t("Select Allocate Data Set to create now, or Edit Attributes to review values"),
247265
ignoreFocusOut: true,
248266
canPickMany: false,
249267
};

0 commit comments

Comments
 (0)