Initial Release

Author: zph

.goreleaser.yaml

@@ -14,8 +14,6 @@ before:
     - go mod tidy
     # you may remove this if you don't need go generate
     - go generate ./...
-    - echo '{"version":"{{ .Version }}", "tag":"{{ .Tag }}", "commit":"{{ .Commit }}", "date":"{{ .Date }}"}' >> pkg/VERSION.json
-    - git add pkg/VERSION.json && git commit -m "Update VERSION.json"
 
 builds:
   - env: []

Makefile

@@ -8,7 +8,7 @@ build:
 
 run:
 	go build -o ${BINARY_PATH}
-	${BINARY_NAME} ~/src/runbook
+	${BINARY_NAME} run ~/src/runbook
 
 clean:
 	go clean
@@ -23,5 +23,8 @@ test-watch:
 benchmark:
 	hyperfine --ignore-failure -- "./bin/polylint --config examples/simple.yaml run ~/src/runbook"
 
-build-dry-run:
+release-dry-run:
 	goreleaser release --clean --skip publish --snapshot
+
+release:
+	goreleaser release --clean

cmd/root.go

@@ -9,7 +9,6 @@ import (
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
-	pkg "github.com/zph/polylint/pkg"
 )
 
 var (
@@ -43,9 +42,6 @@ func init() {
 }
 
 func setVersion() {
-	if version == "v0.0.1" {
-		version = pkg.LibMetadata.Version
-	}
 	viper.Set("binary_version", version)
 	rootCmd.Version = version
 }

cmd/run.go

@@ -67,7 +67,7 @@ func Run(cmd *cobra.Command, args []string) (int, []error) {
 					fmt.Printf("\n%s: violations count %d\n", result.Path, len(result.Findings))
 					for idx, finding := range result.Findings {
 						// TODO: figure out why the rule embedded is wrong
-						fmt.Printf("%d: %s:%d %s %s\n", idx+1, result.Path, finding.LineNo, finding.RuleId, finding.Rule.Description)
+						fmt.Printf("%d: Line %3d %30s %20s\n", idx+1, finding.LineNo, finding.RuleId, finding.Rule.Description)
 					}
 					exitCode = 1
 				}

examples/simple.yaml

@@ -19,7 +19,8 @@ rules:
     type: builtin
     scope: line
     name: contains
-    args: ['print(']
+    args:
+    - print(
 - id: no-logging
   description: "Don't use logging"
   recommendation: "Use print instead."
@@ -31,7 +32,8 @@ rules:
     type: builtin
     scope: line
     name: regexp
-    args: ['^logging']
+    args:
+    - '^logging'
 - id: no-print-js
   description: "Don't use print()"
   recommendation: "Use logging instead."
@@ -42,11 +44,9 @@ rules:
   fn:
     type: js
     scope: line
-    name: printRule
+    name: fn
     body: |
-      function printRule(path, idx, line) {
-        return line.includes('print')
-      }
+      const fn = (_p, _i, line) => line.includes('print')
 - id: no-print-js-file-level
   description: "Don't use print()"
   recommendation: "Use logging instead."
@@ -57,11 +57,8 @@ rules:
   fn:
     type: js
     scope: file
-    name: printRule
-    body: |
-      function printRule(path, idx, line) {
-        return line.includes('print')
-      }
+    name: fn
+    body: const fn = (_p, _i, file) => file.includes('print')
 - id: no-print-js-path-level
   description: "Don't use print()"
   recommendation: "Use logging instead."
@@ -72,8 +69,5 @@ rules:
   fn:
     type: js
     scope: path
-    name: printRule
-    body: |
-      function printRule(path, _idx, _line) {
-        return path.includes('print')
-      }
+    name: fn
+    body: const fn = (path, _i, _l) => path.includes('print')