Skip to content

Commit 095c87e

Browse files
committed
Ensure Buildx steps fail fast if TiDB images don't exist
Add continue-on-error: false to Buildx steps so they fail immediately if Docker images don't exist, rather than silently continuing and causing confusing errors later.
1 parent f1dc683 commit 095c87e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/main.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,10 @@ jobs:
209209
if: contains(matrix.target, 'tidb')
210210
uses: docker/setup-buildx-action@v3
211211

212-
- name: Cache TiDB Docker images using Buildx
212+
- name: Pull and cache TiDB Docker images using Buildx
213213
if: contains(matrix.target, 'tidb')
214214
uses: docker/build-push-action@v5
215+
continue-on-error: false
215216
with:
216217
context: .
217218
file: Dockerfile.tidb
@@ -223,9 +224,10 @@ jobs:
223224
cache-from: type=gha,scope=tidb-v${{ steps.extract-tidb-version.outputs.version }}
224225
cache-to: type=gha,mode=max,scope=tidb-v${{ steps.extract-tidb-version.outputs.version }}
225226

226-
- name: Cache PD Docker image using Buildx
227+
- name: Pull and cache PD Docker image using Buildx
227228
if: contains(matrix.target, 'tidb')
228229
uses: docker/build-push-action@v5
230+
continue-on-error: false
229231
with:
230232
context: .
231233
file: Dockerfile.tidb
@@ -237,9 +239,10 @@ jobs:
237239
cache-from: type=gha,scope=pd-v${{ steps.extract-tidb-version.outputs.version }}
238240
cache-to: type=gha,mode=max,scope=pd-v${{ steps.extract-tidb-version.outputs.version }}
239241

240-
- name: Cache TiKV Docker image using Buildx
242+
- name: Pull and cache TiKV Docker image using Buildx
241243
if: contains(matrix.target, 'tidb')
242244
uses: docker/build-push-action@v5
245+
continue-on-error: false
243246
with:
244247
context: .
245248
file: Dockerfile.tidb

0 commit comments

Comments
 (0)