Skip to content

Commit a071ea8

Browse files
committed
Revert Unistore-based smoke tests
Remove Unistore test implementation as it's not needed.
1 parent 7d9b317 commit a071ea8

File tree

6 files changed

+778
-223
lines changed

6 files changed

+778
-223
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 115 deletions
Original file line numberDiff line numberDiff line change
@@ -248,121 +248,6 @@ jobs:
248248
env:
249249
GOFLAGS: -mod=vendor
250250
run: make ${{ matrix.target }}
251-
252-
# Fast Unistore-based smoke tests (latest of each major series)
253-
# These run quickly using Unistore backend for fast feedback
254-
tests-unistore:
255-
runs-on: ubuntu-22.04
256-
needs: [prepare-dependencies]
257-
strategy:
258-
fail-fast: false
259-
matrix:
260-
target:
261-
# Latest of each major series: 6.x, 7.x, 8.x
262-
- testtidb-unistore6.5.12
263-
- testtidb-unistore7.5.7
264-
- testtidb-unistore8.5.3
265-
steps:
266-
- name: Checkout Git repo
267-
uses: actions/checkout@v4
268-
with:
269-
fetch-depth: 1
270-
271-
- name: Set up Go
272-
uses: actions/setup-go@v4
273-
with:
274-
go-version-file: go.mod
275-
276-
- name: Download Terraform binary
277-
uses: actions/download-artifact@v4
278-
with:
279-
name: terraform-binary
280-
path: bin/
281-
282-
- name: Download vendor directory
283-
uses: actions/download-artifact@v4
284-
with:
285-
name: vendor-dir
286-
path: vendor/
287-
288-
- name: Make Terraform executable
289-
run: chmod +x bin/terraform
290-
291-
- name: Cache apt packages
292-
uses: actions/cache@v4
293-
with:
294-
path: /var/cache/apt
295-
key: ${{ runner.os }}-apt-${{ hashFiles('**/.github/workflows/main.yml') }}
296-
restore-keys: |
297-
${{ runner.os }}-apt-
298-
299-
- name: Install mysql client
300-
run: |
301-
sudo apt-get update -qq
302-
sudo apt-get install -y --no-install-recommends mysql-client
303-
304-
- name: Extract TiDB version from test target
305-
id: extract-tidb-version-unistore
306-
run: |
307-
# Extract version from testtidb-unistore6.5.12 -> 6.5.12
308-
VERSION=$(echo "${{ matrix.target }}" | sed 's/testtidb-unistore//')
309-
echo "version=${VERSION}" >> $GITHUB_OUTPUT
310-
echo "TiDB version for Unistore smoke test: ${VERSION}"
311-
312-
- name: Cache TiUP binary (shared across all TiDB tests)
313-
id: cache-tiup-binary-unistore
314-
uses: actions/cache@v4
315-
with:
316-
path: |
317-
~/.tiup/bin
318-
~/.tiup/manifests
319-
# Cache TiUP binary separately (small, ~20MB) - shared by all TiDB tests
320-
key: ${{ runner.os }}-tiup-binary-${{ hashFiles('.github/workflows/main.yml') }}
321-
restore-keys: |
322-
${{ runner.os }}-tiup-binary-
323-
324-
- name: Cache TiDB components for this specific version
325-
id: cache-tidb-version-unistore
326-
uses: actions/cache@v4
327-
with:
328-
path: |
329-
~/.tiup/components
330-
# Cache components directory per version (~700-800MB per version)
331-
key: ${{ runner.os }}-tidb-${{ steps.extract-tidb-version-unistore.outputs.version }}-${{ hashFiles('.github/workflows/main.yml') }}
332-
restore-keys: |
333-
${{ runner.os }}-tidb-${{ steps.extract-tidb-version-unistore.outputs.version }}-
334-
335-
- name: Install TiUP (if not cached)
336-
run: |
337-
if ! command -v tiup &> /dev/null; then
338-
curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh
339-
echo "$HOME/.tiup/bin" >> $GITHUB_PATH
340-
else
341-
echo "$HOME/.tiup/bin" >> $GITHUB_PATH
342-
fi
343-
344-
- name: Update TiUP and playground component
345-
run: |
346-
export PATH=$HOME/.tiup/bin:$PATH
347-
tiup update --self || true
348-
tiup update playground || true
349-
350-
- name: Install TiDB components for this version (if not cached)
351-
if: steps.cache-tidb-version-unistore.outputs.cache-hit != 'true'
352-
run: |
353-
export PATH=$HOME/.tiup/bin:$PATH
354-
VERSION="${{ steps.extract-tidb-version-unistore.outputs.version }}"
355-
echo "Installing TiDB components for v${VERSION} (cache miss)..."
356-
tiup install tidb:v${VERSION} || true
357-
tiup install pd:v${VERSION} || true
358-
# Note: TiKV not needed for Unistore, but install for cache consistency
359-
tiup install tikv:v${VERSION} || true
360-
echo "TiDB v${VERSION} components installed and will be cached for next run"
361-
362-
- name: Run Unistore smoke tests {{ matrix.target }}
363-
env:
364-
GOFLAGS: -mod=vendor
365-
run: make ${{ matrix.target }}
366251
# DISABLED to figure out GPG signing issue on Github Actions
367252
# possibly due to lack of TTY inside docker?
368253
# release:

GNUmakefile

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -95,18 +95,6 @@ testtidb:
9595
MYSQL_VERSION=$(MYSQL_VERSION) MYSQL_PORT=$(MYSQL_PORT) $(CURDIR)/scripts/tidb-playground.sh stop; \
9696
exit $$TEST_RESULT
9797

98-
# Fast Unistore-based smoke tests (latest of each major series)
99-
testtidb-unistore%:
100-
$(MAKE) MYSQL_VERSION=$* MYSQL_PORT=35$(shell echo "$*" | tr -d '.') testtidb-unistore
101-
102-
# WARNING: this does not work as a bare task run, it only instantiates correctly inside the versioned TiDB task run
103-
testtidb-unistore:
104-
@MYSQL_VERSION=$(MYSQL_VERSION) MYSQL_PORT=$(MYSQL_PORT) $(CURDIR)/scripts/tidb-playground-unistore.sh start || exit 1
105-
MYSQL_USERNAME="$(TEST_USER)" MYSQL_PASSWORD="" MYSQL_ENDPOINT=127.0.0.1:$(MYSQL_PORT) $(MAKE) testacc; \
106-
TEST_RESULT=$$?; \
107-
MYSQL_VERSION=$(MYSQL_VERSION) MYSQL_PORT=$(MYSQL_PORT) $(CURDIR)/scripts/tidb-playground-unistore.sh stop; \
108-
exit $$TEST_RESULT
109-
11098
testmariadb%:
11199
$(MAKE) MYSQL_VERSION=$* MYSQL_PORT=6$(shell echo "$*" | tr -d '.') testmariadb
112100

0 commit comments

Comments
 (0)